[kexec-tools] dump_localfs error path fix
Dave Young
yangrr at fedoraproject.org
Mon Jul 23 07:41:03 UTC 2012
commit 3d470c4be28d82874568c7d1256659fe92d0ffa0
Author: Dave Young <dyoung at redhat.com>
Date: Mon Jul 23 15:31:08 2012 +0800
dump_localfs error path fix
in dump_localfs, we should error out if fstab mount fails
Also error out if mkdir fails.
vivek: display error message for debugging purpose.
Signed-off-by: Dave Young <dyoung at redhat.com>
Acked-by: Vivek Goyal <vgoyal at redhat.com>
dracut-kdump.sh | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
---
diff --git a/dracut-kdump.sh b/dracut-kdump.sh
index 2717820..8986cf0 100755
--- a/dracut-kdump.sh
+++ b/dracut-kdump.sh
@@ -85,11 +85,16 @@ dump_localfs()
{
local _dev=`to_dev_name $1`
local _mp=`get_mp $_dev`
+
+ if [ -z "$_mp" ]; then
+ echo "kdump: error: Dump target $1 is not mounted."
+ return 1
+ fi
if [ "$_mp" = "$NEWROOT/" ] || [ "$_mp" = "$NEWROOT" ]
then
mount -o remount,rw $_mp || return 1
fi
- mkdir -p $_mp/$KDUMP_PATH/$DATEDIR
+ mkdir -p $_mp/$KDUMP_PATH/$DATEDIR || return 1
$CORE_COLLECTOR /proc/vmcore $_mp/$KDUMP_PATH/$DATEDIR/vmcore || return 1
umount $_mp || return 1
return 0
More information about the scm-commits
mailing list