[python-cliapp] Proper fix: remove build directory completely before coverage testing

Michel Alexandre Salim salimma at fedoraproject.org
Tue Jun 5 04:54:50 UTC 2012


commit 63cab8c2da122bb6e30b05af7dfab6fbf819f0c7
Author: Michel Alexandre Salim <salimma at fedoraproject.org>
Date:   Tue Jun 5 11:54:20 2012 +0700

    Proper fix: remove build directory completely before coverage testing

 python-cliapp.spec |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/python-cliapp.spec b/python-cliapp.spec
index eeea144..53b0b78 100644
--- a/python-cliapp.spec
+++ b/python-cliapp.spec
@@ -43,9 +43,9 @@ make
 
 
 %check
-# we run checks *after* building, whereas upstream expected that to happen
-# before -- exclude the build directory
-echo "./build" >> without-tests
+# CoverageTestRunner trips up on build directory;
+# since we've already done the install phase, remove it first
+rm -rf build
 make check
 
 
@@ -63,7 +63,7 @@ make check
 * Tue Jun  5 2012 Michel Salim <salimma at fedoraproject.org> - 0.29-2
 - Remove unneeded %%{python_sitelib} declaration
 - Make file listing more specific
-- Exclude the Python build directory from coverage testing
+- Remove build directory before running coverage test
 
 * Sun Jun  3 2012 Michel Salim <salimma at fedoraproject.org> - 0.29-1
 - Initial package


More information about the scm-commits mailing list