[php-channel-twig] Multiple updates per review

Shawn Iwinski siwinski at fedoraproject.org
Sat Jun 9 05:51:29 UTC 2012


commit a4f94bdfb70da9786dfd5e4976bb31686bc4df7a
Author: Shawn Iwinski <shawn.iwinski at gmail.com>
Date:   Sat Jun 9 01:33:26 2012 -0400

    Multiple updates per review
    
    - %global instead of %define
    - Removed BuildRoot
    - Removed %defattr from %files section
    - Minor syntax update in %post section

 php-channel-twig.spec |   14 +++++++++-----
 1 files changed, 9 insertions(+), 5 deletions(-)
---
diff --git a/php-channel-twig.spec b/php-channel-twig.spec
index a7f438b..02c1fcc 100644
--- a/php-channel-twig.spec
+++ b/php-channel-twig.spec
@@ -1,9 +1,9 @@
 %{!?__pear: %{expand: %%global __pear %{_bindir}/pear}}
-%define pear_channel pear.twig-project.org
+%global pear_channel pear.twig-project.org
 
 Name:             php-channel-twig
 Version:          1.0
-Release:          1%{?dist}
+Release:          2%{?dist}
 Summary:          Adds %{pear_channel} channel to PEAR
 
 Group:            Development/Libraries
@@ -11,7 +11,6 @@ License:          BSD
 URL:              http://%{pear_channel}
 Source0:          http://%{pear_channel}/channel.xml
 
-BuildRoot:        %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 BuildArch:        noarch
 BuildRequires:    php-pear >= 1:1.4.9-1.2
 BuildRequires:    php-pear(PEAR)
@@ -49,7 +48,7 @@ install -pm 644 %{SOURCE0} $RPM_BUILD_ROOT%{pear_xmldir}/%{name}.xml
 if [ $1 -eq  1 ] ; then
    %{__pear} channel-add %{pear_xmldir}/%{name}.xml > /dev/null || :
 else
-   %{__pear} channel-update %{pear_xmldir}/%{name}.xml > /dev/null ||:
+   %{__pear} channel-update %{pear_xmldir}/%{name}.xml > /dev/null || :
 fi
 
 
@@ -60,10 +59,15 @@ fi
 
 
 %files
-%defattr(-,root,root,-)
 %{pear_xmldir}/%{name}.xml
 
 
 %changelog
+* Sun May 20 2012 Shawn Iwinski <shawn.iwinski at gmail.com> 1.0-2
+- %%global instead of %%define
+- Removed BuildRoot
+- Removed %%defattr from %%files section
+- Minor syntax update in %%post section
+
 * Fri Apr 27 2012 Shawn Iwinski <shawn.iwinski at gmail.com> 1.0-1
 - Initial package


More information about the scm-commits mailing list