[gnome-boxes/f17] Fix Boxes with GTK+ 3.4
Christophe Fergeau
teuf at fedoraproject.org
Tue Jun 26 13:31:44 UTC 2012
commit 30cd4689b005e2925b1a609f75a95668c202ce8a
Author: Christophe Fergeau <cfergeau at redhat.com>
Date: Tue Jun 26 15:16:54 2012 +0200
Fix Boxes with GTK+ 3.4
The parsing of our CSS stylesheet failed, causing a bad look.
Fix-parsing-of-CSS-stylesheet-with-gtk-3.4.patch | 36 ++++++++++++++++++++++
gnome-boxes.spec | 8 ++++-
2 files changed, 43 insertions(+), 1 deletions(-)
---
diff --git a/Fix-parsing-of-CSS-stylesheet-with-gtk-3.4.patch b/Fix-parsing-of-CSS-stylesheet-with-gtk-3.4.patch
new file mode 100644
index 0000000..1480093
--- /dev/null
+++ b/Fix-parsing-of-CSS-stylesheet-with-gtk-3.4.patch
@@ -0,0 +1,36 @@
+From f973b38e04d7b082ffe8d68de28332792744e8be Mon Sep 17 00:00:00 2001
+From: Christophe Fergeau <cfergeau at redhat.com>
+Date: Tue, 26 Jun 2012 14:52:38 +0200
+Subject: [PATCH] Fix parsing of CSS stylesheet with gtk+ 3.4
+
+gtk+ 3.4 expects the horizontal and vertical offsets of text-shadow
+and icon-shadow CSS properties to be unitless otherwise it fails
+to parse them, and it returns an error parsing the whole CSS stylesheet
+("Horizontal and vertical offsets are required").
+This causes GNOME Boxes to be wrongly styled/themed, and looks ugly.
+This will be fixed with gtk+ 3.6, but in the 3.4 series, let's go
+with an easy fix and remove units from these properties.
+
+https://bugzilla.gnome.org/show_bug.cgi?id=678876
+---
+ data/gtk-style.css | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/data/gtk-style.css b/data/gtk-style.css
+index 9af959b..9c01a6d 100644
+--- a/data/gtk-style.css
++++ b/data/gtk-style.css
+@@ -102,8 +102,8 @@
+ background-image: none;
+ background-color: alpha(#fff, 0.15);
+
+- text-shadow: 1px 1px black;
+- icon-shadow: 1px 1px black;
++ text-shadow: 1 1 black;
++ icon-shadow: 1 1 black;
+ }
+
+ .osd .toolbar .favorite {
+--
+1.7.10.2
+
diff --git a/gnome-boxes.spec b/gnome-boxes.spec
index 13e8aee..2b02643 100644
--- a/gnome-boxes.spec
+++ b/gnome-boxes.spec
@@ -3,13 +3,14 @@
Name: gnome-boxes
Version: 3.4.3
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: A simple GNOME 3 application to access remote or virtual systems
Group: Applications/Emulators
License: LGPLv2+
URL: https://live.gnome.org/Boxes
Source0: http://download.gnome.org/sources/%{name}/%{url_ver}/%{name}-%{version}.tar.xz
+Patch0: Fix-parsing-of-CSS-stylesheet-with-gtk-3.4.patch
BuildRequires: intltool
BuildRequires: vala-devel >= 0.14.0
@@ -54,6 +55,7 @@ gnome-boxes lets you easily create, setup, access, and use:
%prep
%setup -q
+%patch0 -p1
%build
#fedora-legal and the fedora board permit logos to be enabled
@@ -96,6 +98,10 @@ glib-compile-schemas %{_datadir}/glib-2.0/schemas &> /dev/null || :
%{_datadir}/icons/hicolor/*/apps/gnome-boxes.*
%changelog
+* Tue Jun 26 2012 Christophe Fergeau <cfergeau at redhat.com> - 3.4.3-2
+- Fix parsing of GNOME Boxes CSS stylesheet, causes ugly Boxes look
+ with GTK+ 3.4
+
* Sun Jun 10 2012 Zeeshan Ali <zeenix at redhat.com> - 3.4.3-1
- Update to 3.4.3
More information about the scm-commits
mailing list