[perl-Test-Kwalitee] Spec clean-up

[Paul Howarth]

commit 62ec9cd1c5d82700763f5aa0f9413879e4c25dd7
Author: Paul Howarth <paul at city-fan.org>
Date:   Thu Mar 8 23:05:08 2012 +0000

    Spec clean-up
    
    - BR: perl(Cwd), perl(strict), perl(Test::Builder), perl(vars), perl(warnings)
    - Don't need to remove empty directories from buildroot
    - Don't use macros for commands
    - Make %files list more explicit
    - Drop %defattr, redundant since rpm 4.4
    - Use tabs

 .gitignore              |    2 +-
 perl-Test-Kwalitee.spec |   75 ++++++++++++++++++++++++++--------------------
 2 files changed, 43 insertions(+), 34 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index 71d2b8b..811a582 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1 @@
-Test-Kwalitee-1.01.tar.gz
+/Test-Kwalitee-[0-9.]*.tar.gz
diff --git a/perl-Test-Kwalitee.spec b/perl-Test-Kwalitee.spec
index 7cb6119..d2442bb 100644
--- a/perl-Test-Kwalitee.spec
+++ b/perl-Test-Kwalitee.spec
@@ -1,54 +1,63 @@
-Name:           perl-Test-Kwalitee
-Version:        1.01
-Release:        11%{?dist}
-Summary:        Test the Kwalitee of a distribution before you release it
-License:        GPL+ or Artistic
-Group:          Development/Libraries
-URL:            http://search.cpan.org/dist/Test-Kwalitee/
-Source0:        http://www.cpan.org/authors/id/C/CH/CHROMATIC/Test-Kwalitee-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildArch:      noarch
-BuildRequires:  perl(Module::Build)
-BuildRequires:  perl(Module::CPANTS::Analyse) >= 0.82
-BuildRequires:  perl(Test::Simple) >= 0.47
-BuildRequires:  perl(Test::Pod::Coverage) >= 1.04
-BuildRequires:  perl(Test::Pod) >= 1.14
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Name:		perl-Test-Kwalitee
+Version:	1.01
+Release:	12%{?dist}
+Summary:	Test the Kwalitee of a distribution before you release it
+License:	GPL+ or Artistic
+Group:		Development/Libraries
+URL:		http://search.cpan.org/dist/Test-Kwalitee/
+Source0:	http://search.cpan.org/CPAN/authors/id/C/CH/CHROMATIC/Test-Kwalitee-%{version}.tar.gz
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+BuildArch:	noarch
+BuildRequires:	perl(Cwd)
+BuildRequires:	perl(Module::Build)
+BuildRequires:	perl(Module::CPANTS::Analyse) >= 0.82
+BuildRequires:	perl(strict)
+BuildRequires:	perl(Test::Builder)
+BuildRequires:	perl(Test::Pod::Coverage) >= 1.04
+BuildRequires:	perl(Test::Pod) >= 1.14
+BuildRequires:	perl(Test::Simple) >= 0.47
+BuildRequires:	perl(vars)
+BuildRequires:	perl(warnings)
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 
 %description
 Kwalitee is an automatically-measurable gauge of how good your software
 is. That's very different from quality, which a computer really can't
-measure in a general sense. (If you can, you've solved a hard problem in
-computer science.)
+measure in a general sense (if you can, you've solved a hard problem in
+computer science).
 
 %prep
 %setup -q -n Test-Kwalitee-%{version}
 
 %build
-%{__perl} Build.PL installdirs=vendor
+perl Build.PL installdirs=vendor
 ./Build
 
 %install
-rm -rf $RPM_BUILD_ROOT
-
-./Build install destdir=$RPM_BUILD_ROOT create_packlist=0
-find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} $RPM_BUILD_ROOT/*
+rm -rf %{buildroot}
+./Build install destdir=%{buildroot} create_packlist=0
+%{_fixperms} %{buildroot}
 
 %check
 ./Build test
 
 %clean
-rm -rf $RPM_BUILD_ROOT
+rm -rf %{buildroot}
 
 %files
-%defattr(-,root,root,-)
 %doc ChangeLog README
-%{perl_vendorlib}/*
-%{_mandir}/man3/*
+%{perl_vendorlib}/Test/
+%{_mandir}/man3/Test::Kwalitee.3pm*
 
 %changelog
+* Thu Mar  8 2012 Paul Howarth <paul at city-fan.org> - 1.01-12
+- BR: perl(Cwd), perl(strict), perl(Test::Builder), perl(vars), perl(warnings)
+- Don't need to remove empty directories from buildroot
+- Don't use macros for commands
+- Make %%files list more explicit
+- Drop %%defattr, redundant since rpm 4.4
+- Use tabs
+
 * Fri Jan 13 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.01-11
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
 
@@ -65,13 +74,13 @@ rm -rf $RPM_BUILD_ROOT
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Wed Dec 22 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.01-6
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
 * Thu May 06 2010 Marcela Maslanova <mmaslano at redhat.com> - 1.01-5
 - Mass rebuild with perl-5.12.0
 
 * Fri Dec  4 2009 Stepan Kasal <skasal at redhat.com> - 1.01-4
-- rebuild against perl 5.10.1
+- Rebuild against perl 5.10.1
 
 * Sun Jul 26 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.01-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
@@ -79,5 +88,5 @@ rm -rf $RPM_BUILD_ROOT
 * Thu Feb 26 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.01-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
 
-* Sat Feb 14 2009 Allisson Azevedo <allisson at gmail.com> 1.01-1
-- Initial rpm release.
+* Sat Feb 14 2009 Allisson Azevedo <allisson at gmail.com> - 1.01-1
+- Initial rpm release