[perl-Test-Distribution: 13/13] Spec clean-up

Sat Mar 10 20:15:59 UTC 2012

commit 817e748780bac354367a75f406cdc2c17e27e72a
Author: Paul Howarth <paul at city-fan.org>
Date:   Sat Mar 10 20:14:50 2012 +0000

    Spec clean-up
    
    - BR:perl(ExtUtils::Manifest) and perl(Test::More)
    - Drop workarounds for no-longer-shipped signature test
    - Drop BR: perl(Module::Signature)
    - Don't need to remove empty directories from buildroot
    - Don't use macros for commands
    - Drop %defattr, redundant since rpm 4.4
    - Make %files list more explicit
    - Use tabs

 .gitignore                        |    2 +-
 Test-Distribution-2.00-utf8.patch |   31 +++++++++
 perl-Test-Distribution.spec       |  122 ++++++++++++++++++------------------
 3 files changed, 93 insertions(+), 62 deletions(-)
---

diff --git a/.gitignore b/.gitignore
index 84290bc..2deb99b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1 @@
-Test-Distribution-2.00.tar.gz
+/Test-Distribution-[0-9.]*.tar.gz
diff --git a/Test-Distribution-2.00-utf8.patch b/Test-Distribution-2.00-utf8.patch
new file mode 100644
index 0000000..48a9891
--- /dev/null
+++ b/Test-Distribution-2.00-utf8.patch
@@ -0,0 +1,31 @@
+--- Changes.pod
++++ Changes.pod
+@@ -146,7 +146,7 @@ Thanks to Steffen Schwigon for both of t
+ =item  Test::Distribution now uses the MANIFEST to find modules to test.
+ 
+ It falls back to doing a find for *.pm if no MANIFEST exists.  (thanks to
+-Paul Hughes aka Barbie and Steffen Müller for suggesting this)
++Paul Hughes aka Barbie and Steffen Müller for suggesting this)
+ 
+ =item  Added manifest test.
+ 
+--- README
++++ README
+@@ -220,7 +220,7 @@ SOURCE AVAILABILITY
+     http://sourceforge.net/projects/sagar-r-shah/
+ 
+ AUTHORS
+-    Marcel Grünauer <marcel at cpan.org>
++    Marcel Grünauer <marcel at cpan.org>
+ 
+     Sagar R. Shah
+ 
+@@ -230,7 +230,7 @@ OTHER CREDITS
+     describes an idea by Andy Lester.
+ 
+ COPYRIGHT & LICENSE
+-    Copyright 2002-2003 Marcel Grünauer. All rights reserved.
++    Copyright 2002-2003 Marcel Grünauer. All rights reserved.
+ 
+     Copyright 2003-2007, Sagar R. Shah, All rights reserved.
+ 
diff --git a/perl-Test-Distribution.spec b/perl-Test-Distribution.spec
index edf40e7..b7d63cc 100644
--- a/perl-Test-Distribution.spec
+++ b/perl-Test-Distribution.spec
@@ -1,73 +1,73 @@
-# noarch, but to avoid debug*.list interfering with signature/manifest tests:
-%define debug_package %{nil}
-
-Name:           perl-Test-Distribution
-Version:        2.00
-Release:        10%{?dist}
-Summary:        Perform tests on all modules of a distribution
-License:        GPL+ or Artistic
-Group:          Development/Libraries
-URL:            http://search.cpan.org/dist/Test-Distribution/
-Source0:        http://www.cpan.org/authors/id/S/SR/SRSHAH/Test-Distribution-%{version}.tar.gz
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-BuildArch:      noarch
-
-BuildRequires:  perl(Module::Build)
-BuildRequires:  perl(File::Find::Rule) >= 0.03
-BuildRequires:  perl(Module::CoreList) >= 1.93
-BuildRequires:  perl(Module::Signature)
-BuildRequires:  perl(Pod::Coverage) >= 0.17
-BuildRequires:  perl(Test::Pod) >= 0.95
-BuildRequires:  perl(Test::Pod::Coverage)
-
+Name:		perl-Test-Distribution
+Version:	2.00
+Release:	11%{?dist}
+Summary:	Perform tests on all modules of a distribution
+License:	GPL+ or Artistic
+Group:		Development/Libraries
+URL:		http://search.cpan.org/dist/Test-Distribution/
+Source0:	http://search.cpan.org/CPAN/authors/id/S/SR/SRSHAH/Test-Distribution-%{version}.tar.gz
+Patch0:		Test-Distribution-2.00-utf8.patch
+BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(id -nu)
+BuildArch:	noarch
+BuildRequires:	perl(ExtUtils::Manifest)
+BuildRequires:	perl(File::Find::Rule) >= 0.03
+BuildRequires:	perl(Module::Build)
+BuildRequires:	perl(Module::CoreList) >= 1.93
+BuildRequires:	perl(Pod::Coverage) >= 0.17
+BuildRequires:	perl(Test::More)
+BuildRequires:	perl(Test::Pod) >= 0.95
+BuildRequires:	perl(Test::Pod::Coverage)
+Requires:	perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 # these are considered "optional"; autoreq doesn't pick them up
-Requires:       perl(File::Find::Rule) >= 0.03
-Requires:       perl(Module::CoreList) >= 1.93
-Requires:       perl(Module::Signature)
-Requires:       perl(Pod::Coverage) >= 0.17
-Requires:       perl(Test::Pod) >= 0.95
-Requires:       perl(Test::Pod::Coverage)
-
-Requires:       perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:	perl(File::Find::Rule) >= 0.03
+Requires:	perl(Module::CoreList) >= 1.93
+Requires:	perl(Module::Signature)
+Requires:	perl(Pod::Coverage) >= 0.17
+Requires:	perl(Test::Pod) >= 0.95
+Requires:	perl(Test::Pod::Coverage)
 
 %description
 When using this module in a test script, it goes through all the modules in
-your distribution, checks their POD, checks that they compile ok and checks
+your distribution, checks their POD, checks that they compile OK and checks
 that they all define a $VERSION.
 
 %prep
 %setup -q -n Test-Distribution-%{version}
 
+# Fix character encoding of documentation
+%patch0
+
 %build
-%{__perl} Build.PL installdirs=vendor
+perl Build.PL installdirs=vendor
 ./Build
 
 %install
 rm -rf %{buildroot}
-
 ./Build install destdir=%{buildroot} create_packlist=0
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \;
-
-%{_fixperms} %{buildroot}/*
-
+%{_fixperms} %{buildroot}
 
 %check
-# appease Module::Signature
-tmpdir=$(mktemp -d %{_tmppath}/%{name}-%{version}-%{release}.XXXXXX)
-mkdir -m 700 $tmpdir/_gnupg
-export GNUPGHOME=$tmpdir/_gnupg
-./Build test && rm -rf $tmpdir
+./Build test
 
 %clean
 rm -rf %{buildroot}
 
 %files
-%defattr(-,root,root,-)
 %doc Changes.pod README
-%{perl_vendorlib}/*
-%{_mandir}/man3/*
+%{perl_vendorlib}/Test/
+%{_mandir}/man3/Test::Distribution.3pm*
 
 %changelog
+* Sat Mar 10 2012 Paul Howarth <paul at city-fan.org> - 2.00-11
+- BR:perl(ExtUtils::Manifest) and perl(Test::More)
+- Drop workarounds for no-longer-shipped signature test
+- Drop BR: perl(Module::Signature)
+- Don't need to remove empty directories from buildroot
+- Don't use macros for commands
+- Drop %%defattr, redundant since rpm 4.4
+- Make %%files list more explicit
+- Use tabs
+
 * Fri Jan 13 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 2.00-10
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild
 
@@ -78,13 +78,13 @@ rm -rf %{buildroot}
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild
 
 * Wed Dec 22 2010 Marcela Maslanova <mmaslano at redhat.com> - 2.00-7
-- 661697 rebuild for fixing problems with vendorach/lib
+- Rebuild to fix problems with vendorarch/lib (#661697)
 
 * Thu May 06 2010 Marcela Maslanova <mmaslano at redhat.com> - 2.00-6
 - Mass rebuild with perl-5.12.0
 
 * Fri Dec  4 2009 Stepan Kasal <skasal at redhat.com> - 2.00-5
-- rebuild against perl 5.10.1
+- Rebuild against perl 5.10.1
 
 * Sun Jul 26 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 2.00-4
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild
@@ -92,24 +92,24 @@ rm -rf %{buildroot}
 * Thu Feb 26 2009 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 2.00-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_11_Mass_Rebuild
 
-* Sun Oct 26 2008 Chris Weyl <cweyl at alumni.drew.edu> 2.00-2
+* Sun Oct 26 2008 Chris Weyl <cweyl at alumni.drew.edu> - 2.00-2
 - Changes -> Changes.pod in doc
 
-* Sun Oct 26 2008 Chris Weyl <cweyl at alumni.drew.edu> 2.00-1
-- update to 2.00
+* Sun Oct 26 2008 Chris Weyl <cweyl at alumni.drew.edu> - 2.00-1
+- Update to 2.00
 
-* Wed Mar  5 2008 Tom "spot" Callaway <tcallawa at redhat.com> 1.26-5
-- rebuild for new perl
+* Wed Mar  5 2008 Tom "spot" Callaway <tcallawa at redhat.com> - 1.26-5
+- Rebuild for new perl
 
-* Sat Mar 10 2007 Chris Weyl <cweyl at alumni.drew.edu> 1.26-4
-- don't mess with debuginfo, just disable it.
-- appease Module::Signature/gpg
+* Sat Mar 10 2007 Chris Weyl <cweyl at alumni.drew.edu> - 1.26-4
+- Don't mess with debuginfo, just disable it
+- Appease Module::Signature/gpg
 
-* Thu Mar 01 2007 Chris Weyl <cweyl at alumni.drew.edu> 1.26-3
-- cause rm to not fail on non-existance of debug*list in check.
+* Thu Mar 01 2007 Chris Weyl <cweyl at alumni.drew.edu> - 1.26-3
+- Cause rm to not fail on non-existance of debug*list in %%check
 
-* Wed Dec 06 2006 Chris Weyl <cweyl at alumni.drew.edu> 1.26-2
-- bump
+* Wed Dec 06 2006 Chris Weyl <cweyl at alumni.drew.edu> - 1.26-2
+- Bump
 
-* Wed Dec 06 2006 Chris Weyl <cweyl at alumni.drew.edu> 1.26-1
-- Specfile autogenerated by cpanspec 1.69.1.
+* Wed Dec 06 2006 Chris Weyl <cweyl at alumni.drew.edu> - 1.26-1
+- Specfile autogenerated by cpanspec 1.69.1
