[kernel/f17] drm-i915-dp-stfu.patch: Muzzle a bunch of DP WARN()s. They're not wrong,
Adam Jackson
ajax at fedoraproject.org
Fri Mar 16 20:49:46 UTC 2012
commit efa8ce08777b6e11f342174f16083b99f4290e8e
Author: Adam Jackson <ajax at redhat.com>
Date: Fri Mar 16 16:49:43 2012 -0400
drm-i915-dp-stfu.patch: Muzzle a bunch of DP WARN()s. They're not wrong,
but they're not helpful at this point.
drm-i915-dp-stfu.patch | 69 ++++++++++++++++++++++++++++++++++++++++++++++++
kernel.spec | 6 ++++
2 files changed, 75 insertions(+), 0 deletions(-)
---
diff --git a/drm-i915-dp-stfu.patch b/drm-i915-dp-stfu.patch
new file mode 100644
index 0000000..8948229
--- /dev/null
+++ b/drm-i915-dp-stfu.patch
@@ -0,0 +1,69 @@
+From 04a43e2598db35b3d0ec25925bb8475b5c0a3809 Mon Sep 17 00:00:00 2001
+From: Adam Jackson <ajax at redhat.com>
+Date: Fri, 16 Mar 2012 16:39:11 -0400
+Subject: [PATCH] drm/i915/dp: Use DRM_ERROR not WARN for sanity checks
+
+These are noisy as shit and creating a ton of abrt reports. I don't
+need more, thanks. Proper fix upstream eventually.
+
+Signed-off-by: Adam Jackson <ajax at redhat.com>
+---
+ drivers/gpu/drm/i915/intel_dp.c | 14 ++++++++------
+ 1 files changed, 8 insertions(+), 6 deletions(-)
+
+diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
+index 94f860c..6bf27c9 100644
+--- a/drivers/gpu/drm/i915/intel_dp.c
++++ b/drivers/gpu/drm/i915/intel_dp.c
+@@ -331,7 +331,7 @@ intel_dp_check_edp(struct intel_dp *intel_dp)
+ if (!is_edp(intel_dp))
+ return;
+ if (!ironlake_edp_have_panel_power(intel_dp) && !ironlake_edp_have_panel_vdd(intel_dp)) {
+- WARN(1, "eDP powered off while attempting aux channel communication.\n");
++ DRM_ERROR("eDP powered off while attempting aux channel communication.\n");
+ DRM_DEBUG_KMS("Status 0x%08x Control 0x%08x\n",
+ I915_READ(PCH_PP_STATUS),
+ I915_READ(PCH_PP_CONTROL));
+@@ -386,7 +386,7 @@ intel_dp_aux_ch(struct intel_dp *intel_dp,
+ }
+
+ if (try == 3) {
+- WARN(1, "dp_aux_ch not started status 0x%08x\n",
++ DRM_ERROR("dp_aux_ch not started status 0x%08x\n",
+ I915_READ(ch_ctl));
+ return -EBUSY;
+ }
+@@ -992,8 +992,8 @@ static void ironlake_edp_panel_vdd_on(struct intel_dp *intel_dp)
+ return;
+ DRM_DEBUG_KMS("Turn eDP VDD on\n");
+
+- WARN(intel_dp->want_panel_vdd,
+- "eDP VDD already requested on\n");
++ if (intel_dp->want_panel_vdd)
++ DRM_ERROR("eDP VDD already requested on\n");
+
+ intel_dp->want_panel_vdd = true;
+
+@@ -1058,7 +1058,8 @@ static void ironlake_edp_panel_vdd_off(struct intel_dp *intel_dp, bool sync)
+ return;
+
+ DRM_DEBUG_KMS("Turn eDP VDD off %d\n", intel_dp->want_panel_vdd);
+- WARN(!intel_dp->want_panel_vdd, "eDP VDD not forced on");
++ if (!intel_dp->want_panel_vdd)
++ DRM_ERROR("eDP VDD not forced on");
+
+ intel_dp->want_panel_vdd = false;
+
+@@ -1128,7 +1129,8 @@ static void ironlake_edp_panel_off(struct intel_dp *intel_dp)
+
+ DRM_DEBUG_KMS("Turn eDP power off\n");
+
+- WARN(intel_dp->want_panel_vdd, "Cannot turn power off while VDD is on\n");
++ if (intel_dp->want_panel_vdd)
++ DRM_ERROR("Cannot turn power off while VDD is on\n");
+
+ pp = ironlake_get_pp_control(dev_priv);
+ pp &= ~(POWER_TARGET_ON | EDP_FORCE_VDD | PANEL_POWER_RESET | EDP_BLC_ENABLE);
+--
+1.7.7.6
+
diff --git a/kernel.spec b/kernel.spec
index c24eaa5..ea3a5a4 100644
--- a/kernel.spec
+++ b/kernel.spec
@@ -682,6 +682,7 @@ Patch1800: drm-vgem.patch
# nouveau + drm fixes
# intel drm is all merged upstream
Patch1824: drm-intel-next.patch
+Patch1825: drm-i915-dp-stfu.patch
Patch1900: linux-2.6-intel-iommu-igfx.patch
@@ -1405,6 +1406,7 @@ ApplyPatch drm-vgem.patch
# Intel DRM
ApplyOptionalPatch drm-intel-next.patch
+ApplyPatch drm-i915-dp-stfu.patch
ApplyPatch linux-2.6-intel-iommu-igfx.patch
@@ -2306,6 +2308,10 @@ fi
# '-' | |
# '-'
%changelog
+* Fri Mar 16 2012 Adam Jackson <ajax at redhat.com>
+- drm-i915-dp-stfu.patch: Muzzle a bunch of DP WARN()s. They're not wrong,
+ but they're not helpful at this point.
+
* Fri Mar 16 2012 Dave Jones <davej at redhat.com> - 3.3.0-0.rc7.git2.2
- Disable debugging options.
More information about the scm-commits
mailing list