[kernel/f17] Don't bind the IPS driver if no irq is assigned (typically BIOS bug). (rhbz 804353)

Dave Jones davej at fedoraproject.org
Tue Mar 20 20:51:08 UTC 2012


commit 3b5b9ca4f6ae18cfcc4a67b763ba96596032790d
Author: Dave Jones <davej at redhat.com>
Date:   Tue Mar 20 16:50:59 2012 -0400

    Don't bind the IPS driver if no irq is assigned (typically BIOS bug). (rhbz 804353)

 ips-noirq.patch |   15 +++++++++++++++
 kernel.spec     |    7 +++++++
 2 files changed, 22 insertions(+), 0 deletions(-)
---
diff --git a/ips-noirq.patch b/ips-noirq.patch
new file mode 100644
index 0000000..95837ec
--- /dev/null
+++ b/ips-noirq.patch
@@ -0,0 +1,15 @@
+--- a/drivers/platform/x86/intel_ips.c	
++++ a/drivers/platform/x86/intel_ips.c	
+@@ -1603,6 +1603,12 @@ static int ips_probe(struct pci_dev *dev, const struct pci_device_id *id)
+ 		goto error_unmap;
+ 	}
+ 
++	/* No IRQ assigned is a BIOS failure... */
++	if (dev->irq <= 0) {
++		ret = -ENODEV;
++		goto error_unmap;
++	}
++
+ 	/*
+ 	 * IRQ handler for ME interaction
+ 	 * Note: don't use MSI here as the PCH has bugs.
diff --git a/kernel.spec b/kernel.spec
index 75154a9..e1c3f4d 100644
--- a/kernel.spec
+++ b/kernel.spec
@@ -717,6 +717,8 @@ Patch14000: hibernate-freeze-filesystems.patch
 
 Patch14010: lis3-improve-handling-of-null-rate.patch
 
+Patch19000: ips-noirq.patch
+
 Patch20000: utrace.patch
 
 # Flattened devicetree support
@@ -1439,6 +1441,8 @@ ApplyPatch hibernate-freeze-filesystems.patch
 
 ApplyPatch lis3-improve-handling-of-null-rate.patch
 
+ApplyPatch ips-noirq.patch
+
 # utrace.
 ApplyPatch utrace.patch
 
@@ -2320,6 +2324,9 @@ fi
 #    '-'      |  |
 #              '-'
 %changelog
+* Tue Mar 20 2012 Dave Jones <davej at redhat.com>
+- Don't bind the IPS driver if no irq is assigned (typically BIOS bug). (rhbz 804353)
+
 * Tue Mar 20 2012 Josh Boyer <jwboyer at redhat.com>
 - CVE-2012-1568: execshield: predictable ascii armour base address (rhbz 804957)
 - mac80211: fix possible tid_rx->reorder_timer use after free


More information about the scm-commits mailing list