[accountsservice/f16] fix double free

Ray Strode rstrode at fedoraproject.org
Tue Mar 27 18:09:55 UTC 2012


commit 73eda06ab99ac557fb901059ecea4efe6c5a9c9a
Author: Ray Strode <rstrode at redhat.com>
Date:   Tue Mar 27 14:09:43 2012 -0400

    fix double free

 accountsservice.spec |    9 +++++++--
 double-free.patch    |   11 +++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)
---
diff --git a/accountsservice.spec b/accountsservice.spec
index daecf54..00afb99 100644
--- a/accountsservice.spec
+++ b/accountsservice.spec
@@ -1,7 +1,7 @@
 
 Name:           accountsservice
 Version:        0.6.15
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        D-Bus interfaces for querying and manipulating user account information
 
 Group:          System Environment/Daemons
@@ -21,6 +21,7 @@ Requires:       polkit
 Requires:       shadow-utils
 
 Patch0: 0001-Be-more-careful-when-resetting-the-users-icons.patch
+Patch1: double-free.patch
 
 %package libs
 Summary: Client-side library to talk to accountservice
@@ -51,7 +52,8 @@ of these interfaces, based on the useradd, usermod and userdel commands.
 
 %prep
 %setup -q
-%patch0 -p1
+%patch0 -p1 -b .user-icons
+%patch1 -p1 -b .double-free
 
 %build
 %configure
@@ -90,6 +92,9 @@ rm $RPM_BUILD_ROOT%{_libdir}/*.a
 %{_datadir}/gir-1.0/AccountsService-1.0.gir
 
 %changelog
+* Tue Mar 27 2012 Ray Strode <rstrode at redhat.com> 0.6.15-3
+- Fix double free
+
 * Tue Nov 29 2011 Matthias Clasen <mclasen at redhat.com> 0.6.15-2
 - Make resetting user icons work
 
diff --git a/double-free.patch b/double-free.patch
new file mode 100644
index 0000000..ee3709e
--- /dev/null
+++ b/double-free.patch
@@ -0,0 +1,11 @@
+diff -up accountsservice-0.6.15/src/libaccountsservice/act-user.c.double-free accountsservice-0.6.15/src/libaccountsservice/act-user.c
+--- accountsservice-0.6.15/src/libaccountsservice/act-user.c.double-free	2012-03-27 14:08:31.686200561 -0400
++++ accountsservice-0.6.15/src/libaccountsservice/act-user.c	2012-03-27 14:08:35.352248871 -0400
+@@ -460,7 +460,6 @@ act_user_finalize (GObject *object)
+         g_free (user->shell);
+         g_free (user->email);
+         g_free (user->location);
+-        g_free (user->language);
+ 
+         if (user->accounts_proxy != NULL) {
+                 g_object_unref (user->accounts_proxy);


More information about the scm-commits mailing list