[kernel/f16] Don't bind the IPS driver if no irq is assigned (typically BIOS bug). (rhbz 804353)

Josh Boyer jwboyer at fedoraproject.org
Wed Mar 28 13:32:47 UTC 2012


commit cb6adeaa2b61399606cc3bbb8ad120e93dd6362b
Author: Dave Jones <davej at redhat.com>
Date:   Tue Mar 20 16:50:59 2012 -0400

    Don't bind the IPS driver if no irq is assigned (typically BIOS bug). (rhbz 804353)

 ips-noirq.patch |   15 +++++++++++++++
 kernel.spec     |    7 +++++++
 2 files changed, 22 insertions(+), 0 deletions(-)
---
diff --git a/ips-noirq.patch b/ips-noirq.patch
new file mode 100644
index 0000000..95837ec
--- /dev/null
+++ b/ips-noirq.patch
@@ -0,0 +1,15 @@
+--- a/drivers/platform/x86/intel_ips.c	
++++ a/drivers/platform/x86/intel_ips.c	
+@@ -1603,6 +1603,12 @@ static int ips_probe(struct pci_dev *dev, const struct pci_device_id *id)
+ 		goto error_unmap;
+ 	}
+ 
++	/* No IRQ assigned is a BIOS failure... */
++	if (dev->irq <= 0) {
++		ret = -ENODEV;
++		goto error_unmap;
++	}
++
+ 	/*
+ 	 * IRQ handler for ME interaction
+ 	 * Note: don't use MSI here as the PCH has bugs.
diff --git a/kernel.spec b/kernel.spec
index 5c97197..615201d 100644
--- a/kernel.spec
+++ b/kernel.spec
@@ -734,6 +734,8 @@ Patch14010: lis3-improve-handling-of-null-rate.patch
 
 Patch15000: bluetooth-use-after-free.patch
 
+Patch19000: ips-noirq.patch
+
 Patch20000: utrace.patch
 
 # Flattened devicetree support
@@ -1411,6 +1413,8 @@ ApplyPatch lis3-improve-handling-of-null-rate.patch
 
 ApplyPatch bluetooth-use-after-free.patch
 
+ApplyPatch ips-noirq.patch
+
 # utrace.
 ApplyPatch utrace.patch
 
@@ -2194,6 +2198,9 @@ fi
 # and build.
 
 %changelog
+* Wed Mar 28 2012 Dave Jones <davej at redhat.com>
+- Don't bind the IPS driver if no irq is assigned (typically BIOS bug). (rhbz 804353)
+
 * Tue Mar 27 2012 Josh Boyer <jwboyer at redhat.com>
 - Implement xen apic_ops to fix early crash in Xen Dom0 (rhbz 804347)
 - Apply patch to fix MCE rcu splat (rhbz 789644)


More information about the scm-commits mailing list