[perl-XML-SAX] Update dependencies and Summary. Replace PERL_INSTALL_ROOT with DESTDIR

[Paul Howarth]

Hi Jitka,

On 11/26/2012 08:57 AM, Jitka Plesnikova wrote:
> commit c8fc60b667057f6ed17171ebacd401733b5aa70a
> Author: Jitka Plesnikova <jplesnik at redhat.com>
> Date:   Mon Nov 26 09:53:33 2012 +0100
>
>      Update dependencies and Summary. Replace PERL_INSTALL_ROOT with DESTDIR
>
>   perl-XML-SAX.spec |   18 +++++++++++++++---
>   1 files changed, 15 insertions(+), 3 deletions(-)
> ---
> diff --git a/perl-XML-SAX.spec b/perl-XML-SAX.spec
> index 5082c43..ffadd2d 100644
> --- a/perl-XML-SAX.spec
> +++ b/perl-XML-SAX.spec
> @@ -1,7 +1,7 @@
> -Summary:        XML-SAX Perl module
> +Summary:        SAX parser access API for Perl
>   Name:           perl-XML-SAX
>   Version:        0.99
> -Release:        6%{?dist}
> +Release:        7%{?dist}
>
>   Group:          Development/Libraries
>   License:        GPL+ or Artistic
> @@ -20,6 +20,7 @@ BuildRequires:  perl(Exporter)
>   BuildRequires:  perl(Fatal)
>   BuildRequires:  perl(File::Path)
>   BuildRequires:  perl(File::Spec)
> +BuildRequires:  perl(File::Temp)
>   BuildRequires:  perl(IO::File)
>   BuildRequires:  perl(Test)
>   BuildRequires:  perl(XML::NamespaceSupport) >= 0.03
> @@ -27,6 +28,7 @@ BuildRequires:  perl(XML::NamespaceSupport) >= 0.03
>   BuildRequires:  perl(XML::SAX::Base)
>   BuildRequires:  perl(XML::SAX::Exception)
>   Requires:       perl(:MODULE_COMPAT_%(perl -MConfig -e 'print $Config{version}'))
> +Requires:       perl(perl(LWP::UserAgent)

Too many "perl("s in that addition dependency, will cause broken deps.

> +# xmltest.xml could not be distributed due to copyright
> +rm testfiles/xmltest.xml
> +rm t/16large.t
> +sed -i -e '/testfiles\/xmltest.xml/ d' MANIFEST
> +sed -i -e '/t\/16large.t/ d' MANIFEST

If that file cannot be distributed, it needs to be stripped from the 
tarball prior to uploading to the lookaside cache. Otherwise it'll be 
distributed in the SRPM.

http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code

Cheers, Paul.