[webkitgtk3/f18] Restore compatibility with AMD Geode processors

Daniel Drake dsd at fedoraproject.org
Sat Oct 6 14:54:42 UTC 2012


commit 7a5c155ce2cbda5055e2a7facd48c771f4353796
Author: Daniel Drake <dsd at laptop.org>
Date:   Fri Oct 5 15:17:00 2012 -0600

    Restore compatibility with AMD Geode processors

 webkit-1.10-geode-compat.patch |   30 ++++++++++++++++++++++++++++++
 webkitgtk3.spec                |    7 ++++++-
 2 files changed, 36 insertions(+), 1 deletions(-)
---
diff --git a/webkit-1.10-geode-compat.patch b/webkit-1.10-geode-compat.patch
new file mode 100644
index 0000000..40bed7b
--- /dev/null
+++ b/webkit-1.10-geode-compat.patch
@@ -0,0 +1,30 @@
+2012-10-01  Daniel Drake  <dsd at laptop.org>
+
+        Another SIGILL in JavaScriptCore on a Geode processor
+        https://bugs.webkit.org/show_bug.cgi?id=96286
+
+        Reviewed by Filip Pizlo.
+
+        Disable LLint for the GTK build where the build target does not
+        support SSE2 instructions. Restores support for non-SSE2 processors
+        such as the AMD Geode.
+
+        * wtf/Platform.h:
+ 
+Index: /trunk/Source/WTF/wtf/Platform.h
+===================================================================
+--- /trunk/Source/WTF/wtf/Platform.h	(revision 130075)
++++ /trunk/Source/WTF/wtf/Platform.h	(revision 130076)
+@@ -900,4 +900,12 @@
+ #endif
+ 
++/* On the GTK+ port we take an extra precaution for LLINT support:
++ * We disable it on x86 builds if the build target doesn't support SSE2
++ * instructions (LLINT requires SSE2 on this platform). */
++#if !defined(ENABLE_LLINT) && PLATFORM(GTK) && CPU(X86) && COMPILER(GCC) \
++    && !defined(__SSE2__)
++#define ENABLE_LLINT 0
++#endif
++
+ /* On some of the platforms where we have a JIT, we want to also have the 
+    low-level interpreter. */
diff --git a/webkitgtk3.spec b/webkitgtk3.spec
index 3ffa16d..12dabba 100644
--- a/webkitgtk3.spec
+++ b/webkitgtk3.spec
@@ -7,7 +7,7 @@
 
 Name:           webkitgtk3
 Version:        1.10.0
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        GTK+ Web content engine library
 
 Group:          Development/Libraries
@@ -18,6 +18,7 @@ Source0:        http://webkitgtk.org/releases/webkitgtk-%{version}.tar.xz
 
 Patch1:         webkit-1.3.4-no-execmem.patch
 Patch2:         webkit-1.1.14-nspluginwrapper.patch
+Patch3:         webkit-1.10-geode-compat.patch
 
 BuildRequires:  bison
 BuildRequires:  chrpath
@@ -84,6 +85,7 @@ This package contains developer documentation for %{name}.
 # tbzatek - doesn't apply, is this fixed?
 # %patch1 -p1 -b .no-execmem
 %patch2 -p1 -b .nspluginwrapper
+%patch3 -p2 -b .geode
 
 %build
 %ifarch s390 %{arm} ppc
@@ -196,6 +198,9 @@ glib-compile-schemas %{_datadir}/glib-2.0/schemas &>/dev/null || :
 
 
 %changelog
+* Fri Oct  5 2012 Daniel Drake <dsd at laptop.org> - 1.10.0-2
+- Restore compatibility with AMD Geode processors
+
 * Mon Sep 24 2012 Kalev Lember <kalevlember at gmail.com> - 1.10.0-1
 - Update to 1.10.0
 - Adjust for webkit -> webkitgtk upstream tarball rename


More information about the scm-commits mailing list