[php-symfony2-CssSelector] Added tests

Shawn Iwinski siwinski at fedoraproject.org
Sat Oct 20 03:21:56 UTC 2012


commit d374785e5d7b622fef2779000d693128869ad886
Author: Shawn Iwinski <shawn.iwinski at gmail.com>
Date:   Fri Oct 19 23:18:46 2012 -0400

    Added tests

 .gitignore                    |    1 +
 php-symfony2-CssSelector.spec |   42 +++++++++++++++++++++++++++++++++++++---
 sources                       |    1 +
 tests-bootstrap.patch         |   24 +++++++++++++++++++++++
 4 files changed, 64 insertions(+), 4 deletions(-)
---
diff --git a/.gitignore b/.gitignore
index 293b293..d6a836d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -2,3 +2,4 @@
 /CssSelector-2.0.15.tgz
 /CssSelector-2.0.16.tgz
 /CssSelector-2.0.17.tgz
+/CssSelector-2.1.2.tgz
diff --git a/php-symfony2-CssSelector.spec b/php-symfony2-CssSelector.spec
index 9a12318..2f7bfee 100644
--- a/php-symfony2-CssSelector.spec
+++ b/php-symfony2-CssSelector.spec
@@ -2,6 +2,7 @@
 
 %global pear_channel pear.symfony.com
 %global pear_name    %(echo %{name} | sed -e 's/^php-symfony2-//' -e 's/-/_/g')
+%global php_min_ver  5.3.3
 
 Name:             php-symfony2-CssSelector
 Version:          2.1.2
@@ -12,12 +13,21 @@ Group:            Development/Libraries
 License:          MIT
 URL:              http://symfony.com/doc/current/components/css_selector.html
 Source0:          http://%{pear_channel}/get/%{pear_name}-%{version}.tgz
+Patch0:           tests-bootstrap.patch
 
 BuildArch:        noarch
+
 BuildRequires:    php-pear(PEAR)
 BuildRequires:    php-channel(%{pear_channel})
-
-Requires:         php-common >= 5.3.3
+# Test requires
+BuildRequires:    php-common >= %{php_min_ver}
+BuildRequires:    php-pear(pear.phpunit.de/PHPUnit)
+# Test requires: phpci
+BuildRequires:    php-mbstring
+BuildRequires:    php-pcre
+BuildRequires:    php-spl
+
+Requires:         php-common >= %{php_min_ver}
 Requires:         php-pear(PEAR)
 Requires:         php-channel(%{pear_channel})
 Requires(post):   %{__pear}
@@ -35,6 +45,21 @@ The CssSelector Component converts CSS selectors to XPath expressions.
 
 %prep
 %setup -q -c
+
+# Patches
+cd %{pear_name}-%{version}
+%patch0 -p0
+cd ..
+
+# Modify PEAR package.xml file:
+# - Change role from "php" to "doc" for CHANGELOG.md file
+# - Change role from "php" to "test" for all test files
+sed -e '/CHANGELOG.md/s/role="php"/role="doc"/' \
+    -e '/phpunit.xml.dist/s/role="php"/role="test"/' \
+    -e '/Tests/s/role="php"/role="test"/' \
+    -e '/bootstrap.php/s/md5sum="[^"]*"\s*//' \
+    -i package.xml
+
 # package.xml is version 2.0
 mv package.xml %{pear_name}-%{version}/%{name}.xml
 
@@ -55,6 +80,11 @@ mkdir -p $RPM_BUILD_ROOT%{pear_xmldir}
 install -pm 644 %{name}.xml $RPM_BUILD_ROOT%{pear_xmldir}
 
 
+%check
+cd %{pear_name}-%{version}/Symfony/Component/%{pear_name}
+%{_bindir}/phpunit
+
+
 %post
 %{__pear} install --nodeps --soft --force --register-only \
     %{pear_xmldir}/%{name}.xml >/dev/null || :
@@ -73,13 +103,17 @@ fi
 %dir %{pear_phpdir}/Symfony
 %dir %{pear_phpdir}/Symfony/Component
      %{pear_phpdir}/Symfony/Component/%{pear_name}
+%{pear_testdir}/%{pear_name}
 
 
 %changelog
-* Fri Sep 21 2012 Shawn Iwinski <shawn.iwinski at gmail.com> 2.1.2-1
+* Fri Oct 19 2012 Shawn Iwinski <shawn.iwinski at gmail.com> 2.1.2-1
 - Updated to upstream version 2.1.2
-- Require php-common ">= 5.3.3" instead of ">= 5.3.2"
+- PHP minimum version 5.3.3 instead of 5.3.2
 - Added php-spl require
+- Added PEAR package.xml modifications
+- Added patch for tests' bootstrap.php
+- Added tests (%%check)
 
 * Sat Sep 15 2012 Shawn Iwinski <shawn.iwinski at gmail.com> 2.0.17-1
 - Updated to upstream version 2.0.17
diff --git a/sources b/sources
index 5781a32..21b966b 100644
--- a/sources
+++ b/sources
@@ -1,3 +1,4 @@
 c80b619023b26582a45b7e57ac7d2866  CssSelector-2.0.15.tgz
 c7863b428c923b180ea8342c4547bf8b  CssSelector-2.0.16.tgz
 9d85c2305ff0c90d6a0cd27330cf3865  CssSelector-2.0.17.tgz
+6f273d55a3331de74bfd801c6c01d8fa  CssSelector-2.1.2.tgz
diff --git a/tests-bootstrap.patch b/tests-bootstrap.patch
new file mode 100644
index 0000000..604772c
--- /dev/null
+++ b/tests-bootstrap.patch
@@ -0,0 +1,24 @@
+--- Symfony/Component/CssSelector/Tests/bootstrap.php	2012-09-20 03:42:08.000000000 -0400
++++ Symfony/Component/CssSelector/Tests/bootstrap.php	2012-10-19 23:15:56.672195503 -0400
+@@ -10,9 +10,18 @@
+  */
+ 
+ spl_autoload_register(function ($class) {
+-    if (0 === strpos(ltrim($class, '/'), 'Symfony\Component\CssSelector')) {
+-        if (file_exists($file = __DIR__.'/../'.substr(str_replace('\\', '/', $class), strlen('Symfony\Component\CssSelector')).'.php')) {
+-            require_once $file;
++    if (0 === strpos(ltrim($class, '/'), 'Symfony\Component')) {
++        $file = substr(str_replace('\\', '/', $class), strlen('Symfony\Component')).'.php';
++        if (file_exists(__DIR__.'/../..'.$file)) {
++            // Load from source tree
++            require_once __DIR__.'/../..'.$file;
++        } else {
++            try {
++                // Try loading from incude path
++                require_once 'Symfony/Component'.$file;
++            } catch (Exception $e) {
++                // Fail silently so class not found fatal error still raised
++            }
+         }
+     }
+ });


More information about the scm-commits mailing list