[automake] FedoraReview fixes
Pavel Raiskup
praiskup at fedoraproject.org
Thu Oct 25 12:23:36 UTC 2012
commit e84c05e7bbb397ee732878c65afbef0d6ec75439
Author: Pavel Raiskup <praiskup at redhat.com>
Date: Thu Oct 25 14:14:33 2012 +0200
FedoraReview fixes
automake.spec | 25 ++++++++++---------------
1 files changed, 10 insertions(+), 15 deletions(-)
---
diff --git a/automake.spec b/automake.spec
index f8014a1..66e9508 100644
--- a/automake.spec
+++ b/automake.spec
@@ -1,9 +1,9 @@
-%define api_version 1.12
+%global api_version 1.12
Summary: A GNU tool for automatically creating Makefiles
Name: automake
Version: %{api_version}.2
-Release: 5%{?dist}
+Release: 6%{?dist}
License: GPLv2+ and GFDL
Group: Development/Tools
Source: http://ftp.gnu.org/gnu/automake/automake-%{version}.tar.xz
@@ -53,24 +53,14 @@ make %{?_smp_mflags}
cp m4/acdir/README README.aclocal
cp contrib/multilib/README README.multilib
-
%install
-rm -rf ${RPM_BUILD_ROOT}
-
-make install DESTDIR=${RPM_BUILD_ROOT}
-mkdir -p ${RPM_BUILD_ROOT}%{_mandir}/man1
-
-rm -f ${RPM_BUILD_ROOT}%{_infodir}/dir
-rm -rf ${RPM_BUILD_ROOT}%{_datadir}/aclocal
+make install DESTDIR=%{buildroot}
%check
%if %{with check}
make check
%endif
-%clean
-rm -rf ${RPM_BUILD_ROOT}
-
%post
/sbin/install-info %{_infodir}/automake.info.gz %{_infodir}/dir || :
@@ -80,8 +70,9 @@ if [ $1 = 0 ]; then
fi
%files
-%defattr(-,root,root,-)
%doc AUTHORS README THANKS NEWS README.aclocal README.multilib COPYING*
+%exclude %{_infodir}/dir
+%exclude %{_datadir}/aclocal
%{_bindir}/*
%{_infodir}/*.info*
%{_datadir}/automake-%{api_version}
@@ -89,8 +80,12 @@ fi
%{_mandir}/man1/*
%changelog
+* Wed Oct 25 2012 Pavel Raiskup <praiskup at redhat.com> - 1.12.2-6
+- fedora-review -> s/define/global/, s/RPM_BUILD_ROOT/buildroot/,
+ remove defattr() from %%files section
+
* Wed Sep 26 2012 Pavel Raiskup <praiskup at redhat.com> - 1.12.2-5
-- rather skip failing tests than disabling - previous soulution required
+- rather skip failing tests than disabling - previous solution required
autoreconf (#860577)
* Wed Sep 26 2012 Pavel Raiskup <praiskup at redhat.com> - 1.12.2-4
More information about the scm-commits
mailing list