[sblim-cim-client2] Fix issues found by fedora-review utility in the spec file

vcrhonek vcrhonek at fedoraproject.org
Tue Sep 4 10:30:00 UTC 2012


commit 56e90a4de91698d9985426c28fb1490c2ea3578d
Author: Vitezslav Crhonek <vcrhonek at redhat.com>
Date:   Tue Sep 4 12:29:45 2012 +0200

    Fix issues found by fedora-review utility in the spec file

 sblim-cim-client2.spec |   21 ++++++++-------------
 1 files changed, 8 insertions(+), 13 deletions(-)
---
diff --git a/sblim-cim-client2.spec b/sblim-cim-client2.spec
index 6b619ea..db2f337 100644
--- a/sblim-cim-client2.spec
+++ b/sblim-cim-client2.spec
@@ -4,14 +4,13 @@
 
 Name:           sblim-cim-client2
 Version:        2.1.12
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        Java CIM Client library
 
 Group:          Development/Libraries
 License:        EPL
 URL:            http://sourceforge.net/projects/sblim/
 Source0:        http://downloads.sourceforge.net/project/sblim/%{name}/%{version}/%{name}-%{version}-src.zip
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 BuildArch:      noarch
 
@@ -34,6 +33,7 @@ http://www.jcp.org and http://www.jcp.org/en/jsr/detail?id=48.
 Summary:        Javadoc for %{name}
 Group:          Documentation
 Requires:       sblim-cim-client2 = %{version}-%{release}
+Requires:       jpackage-utils
 
 %description javadoc
 Javadoc for %{name}.
@@ -75,7 +75,6 @@ ant \
 
 
 %install
-rm -rf $RPM_BUILD_ROOT
 # --- documentation ---
 dstDocDir=$RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}
 install -d $dstDocDir
@@ -94,16 +93,11 @@ install %{archive_folder}/lib/%{name}-%{version}.jar $RPM_BUILD_ROOT%{_javadir}/
     ln -sf %{name}-%{version}.jar %{name}.jar;
 )
 # --- javadoc ---
-install -d $RPM_BUILD_ROOT%{_javadocdir}/%{name}-%{version}
-cp -pr %{archive_folder}/doc/* $RPM_BUILD_ROOT%{_javadocdir}/%{name}-%{version}
-
-
-%clean
-rm -rf $RPM_BUILD_ROOT
+install -d $RPM_BUILD_ROOT%{_javadocdir}/%{name}
+cp -pr %{archive_folder}/doc/* $RPM_BUILD_ROOT%{_javadocdir}/%{name}
 
 
 %files
-%defattr(0644,root,root,0755)
 %dir %{_datadir}/doc/%{name}-%{version}
 %config(noreplace) %{_sysconfdir}/java/sblim-cim-client2.properties
 %config(noreplace) %{_sysconfdir}/java/sblim-slp-client2.properties
@@ -115,16 +109,17 @@ rm -rf $RPM_BUILD_ROOT
 %{_javadir}/%{name}-%{version}.jar
 
 %files javadoc
-%defattr(0644,root,root,0755)
-%{_javadocdir}/%{name}-%{version}
+%{_javadocdir}/%{name}
 
 %files manual
-%defattr(0644,root,root,0755)
 %doc %{_docdir}/%{name}-%{version}/COPYING
 %doc %{_docdir}/%{name}-%{version}/org
 
 
 %changelog
+* Tue Sep 04 2012 Vitezslav Crhonek <vcrhonek at redhat.com> - 2.1.12-3
+- Fix issues found by fedora-review utility in the spec file
+
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 2.1.12-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list