[sblim-cmpi-dns] Fix issues found by fedora-review utility in the spec file

vcrhonek vcrhonek at fedoraproject.org
Tue Sep 4 13:40:57 UTC 2012


commit 147d7d872f9ef6f99bdb5dd37fb7da6fa39b3c66
Author: Vitezslav Crhonek <vcrhonek at redhat.com>
Date:   Tue Sep 4 15:40:47 2012 +0200

    Fix issues found by fedora-review utility in the spec file

 sblim-cmpi-dns.spec |   21 ++++++++-------------
 1 files changed, 8 insertions(+), 13 deletions(-)
---
diff --git a/sblim-cmpi-dns.spec b/sblim-cmpi-dns.spec
index 16d741d..2b92c69 100644
--- a/sblim-cmpi-dns.spec
+++ b/sblim-cmpi-dns.spec
@@ -1,16 +1,15 @@
-%define tog_pegasus_version 2:2.5.1
-%define provider_dir %{_libdir}/cmpi/
+%global tog_pegasus_version 2:2.5.1
+%global provider_dir %{_libdir}/cmpi/
 
 Name:           sblim-cmpi-dns
 Version:        1.0
-Release:        6%{?dist}
+Release:        7%{?dist}
 Summary:        SBLIM WBEM-SMT Dns
 
 Group:          Applications/System
 License:        EPL
 URL:            http://sblim.wiki.sourceforge.net/
 Source0:        http://downloads.sourceforge.net/sblim/%{name}-%{version}.tar.bz2
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 Patch0:         sblim-cmpi-dns-0.5.2-include.patch
 
 #BuildRequires:  sed
@@ -72,7 +71,6 @@ sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
 make
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
 # remove unused libtool files
 rm -f $RPM_BUILD_ROOT/%{_libdir}/*a
@@ -83,7 +81,6 @@ echo "%{_libdir}/cmpi" > $RPM_BUILD_ROOT/%{_sysconfdir}/ld.so.conf.d/%{name}-%{_
 sed -i -e '1d;2i#!/usr/bin/awk -f' $RPM_BUILD_ROOT/%{_datadir}/%{name}/smt_dns_ra_lines.awk
 
 %files
-%defattr(-,root,root,0755)
 %{_datadir}/doc/%{name}-%{version}
 %doc %{_mandir}/man5/smt_dns_ra_support.conf.5.gz
 %{_datadir}/%{name}
@@ -96,14 +93,12 @@ sed -i -e '1d;2i#!/usr/bin/awk -f' $RPM_BUILD_ROOT/%{_datadir}/%{name}/smt_dns_r
 %config(noreplace) %{_sysconfdir}/ld.so.conf.d/%{name}-%{_arch}.conf
 
 %files devel
-%defattr(-,root,root,0755)
 %{_includedir}/sblim/smt_dns*.h
 %{_libdir}/libRaToolsDns.so
 %{_libdir}/libIBM_DnsProviderTooling.so
 %{_libdir}/libLinux_DnsGeneralProviderBasic.so
 
 %files test
-%defattr(-,root,root,0755)
 %{_datadir}/sblim-testsuite/elephant.example2.com.conf
 %{_datadir}/sblim-testsuite/buffalo.example2.com.conf
 %{_datadir}/sblim-testsuite/named.conf
@@ -121,8 +116,8 @@ sed -i -e '1d;2i#!/usr/bin/awk -f' $RPM_BUILD_ROOT/%{_datadir}/%{name}/smt_dns_r
 %{_datadir}/sblim-testsuite/cim/Linux_Dns*
 
 # Conditional definition of schema and registration files
-%define DNS_SCHEMA %{_datadir}/%{name}/Linux_Dns_Profile.mof %{_datadir}/%{name}/Linux_Dns.mof
-%define DNS_REGISTRATION %{_datadir}/%{name}/Linux_Dns_Profile.registration %{_datadir}/%{name}/Linux_Dns.registration
+%global DNS_SCHEMA %{_datadir}/%{name}/Linux_Dns_Profile.mof %{_datadir}/%{name}/Linux_Dns.mof
+%global DNS_REGISTRATION %{_datadir}/%{name}/Linux_Dns_Profile.registration %{_datadir}/%{name}/Linux_Dns.registration
 
 %pre
 # If upgrading, deregister old version
@@ -152,10 +147,10 @@ if [ $1 -eq 0 ]; then
   /sbin/ldconfig
 fi
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %changelog
+* Tue Sep 04 2012 Vitezslav Crhonek <vcrhonek at redhat.com> - 1.0-7
+- Fix issues found by fedora-review utility in the spec file
+
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.0-6
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list