[sblim-cmpi-nfsv4] Fix issues found by fedora-review utility in the spec file

vcrhonek vcrhonek at fedoraproject.org
Wed Sep 5 13:39:42 UTC 2012


commit 4193fd1c9c1eaf678ef16483ba587378e1e26833
Author: Vitezslav Crhonek <vcrhonek at redhat.com>
Date:   Wed Sep 5 15:39:18 2012 +0200

    Fix issues found by fedora-review utility in the spec file

 sblim-cmpi-nfsv4.spec |   16 ++++++----------
 1 files changed, 6 insertions(+), 10 deletions(-)
---
diff --git a/sblim-cmpi-nfsv4.spec b/sblim-cmpi-nfsv4.spec
index 6b5793e..1f43a21 100644
--- a/sblim-cmpi-nfsv4.spec
+++ b/sblim-cmpi-nfsv4.spec
@@ -1,12 +1,11 @@
-%define provider_dir %{_libdir}/cmpi
+%global provider_dir %{_libdir}/cmpi
 
 Name:           sblim-cmpi-nfsv4
 Summary:        SBLIM nfsv4 instrumentation
 Version:        1.1.0
-Release:        4%{?dist}
+Release:        5%{?dist}
 License:        EPL
 Group:          Applications/System
-BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 URL:            http://sourceforge.net/projects/sblim/
 Source0:        http://downloads.sourceforge.net/project/sblim/%{name}/%{version}/%{name}-%{version}.tar.bz2
 
@@ -55,7 +54,6 @@ sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool
 make
 
 %install
-rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
 # remove unused libtool files
 rm -f $RPM_BUILD_ROOT/%{_libdir}/*.la
@@ -66,7 +64,6 @@ echo "%{_libdir}/cmpi" > $RPM_BUILD_ROOT/%{_sysconfdir}/ld.so.conf.d/%{name}-%{_
 mv $RPM_BUILD_ROOT/%{_libdir}/libLinux_NFSv4SystemConfigurationUtil.so $RPM_BUILD_ROOT/%{provider_dir}
 
 %files
-%defattr(-,root,root,-)
 %dir %{provider_dir}
 %{provider_dir}/*.so
 %{_datadir}/%{name}
@@ -75,10 +72,9 @@ mv $RPM_BUILD_ROOT/%{_libdir}/libLinux_NFSv4SystemConfigurationUtil.so $RPM_BUIL
 %config(noreplace) %{_sysconfdir}/ld.so.conf.d/%{name}-%{_arch}.conf
 
 %files test
-%defattr(-,root,root,-)
 %{_datadir}/sblim-testsuite
 
-%define PEGASUS_MOF CIM_SystemSetting,CIM_NFS,CIM_SystemConfiguration,CIM_SystemSettingContext
+%global PEGASUS_MOF CIM_SystemSetting,CIM_NFS,CIM_SystemConfiguration,CIM_SystemSettingContext
 
 %pre
 # If upgrading, deregister old version
@@ -115,10 +111,10 @@ fi
 
 %postun -p /sbin/ldconfig
 
-%clean
-rm -rf $RPM_BUILD_ROOT
-
 %changelog
+* Wed Sep 05 2012 Vitezslav Crhonek <vcrhonek at redhat.com> - 1.1.0-5
+- Fix issues found by fedora-review utility in the spec file
+
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.1.0-4
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list