[talk] Fix issues found by fedora-review utility in the spec file

vcrhonek vcrhonek at fedoraproject.org
Mon Sep 10 11:19:28 UTC 2012


commit 1ebfa005d75f905a9a49865493e8e54fe7d4b730
Author: Vitezslav Crhonek <vcrhonek at redhat.com>
Date:   Mon Sep 10 13:19:18 2012 +0200

    Fix issues found by fedora-review utility in the spec file

 talk.spec |   12 ++++--------
 1 files changed, 4 insertions(+), 8 deletions(-)
---
diff --git a/talk.spec b/talk.spec
index 45ef54e..7d05e5d 100644
--- a/talk.spec
+++ b/talk.spec
@@ -1,7 +1,7 @@
 Summary: Talk client for one-on-one Internet chatting
 Name: talk
 Version: 0.17
-Release: 39%{?dist}
+Release: 40%{?dist}
 License: BSD
 Group: Applications/Internet
 # URL: There's no upstream URL at the moment, here's the latest one.
@@ -24,7 +24,6 @@ Patch4: netkit-ntalk-0.17-resize.patch
 # Patch5: Adds support (via new flag) for user names containing dot character
 Patch5: netkit-ntalk-0.17-person.patch
 BuildRequires: ncurses-devel
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 %description
 The talk package provides client programs for the Internet talk 
@@ -73,7 +72,6 @@ terminal to the terminal of another user.
 make
 
 %install
-rm -rf ${RPM_BUILD_ROOT}
 mkdir -p ${RPM_BUILD_ROOT}%{_bindir}
 mkdir -p ${RPM_BUILD_ROOT}%{_mandir}/man{1,8}
 mkdir -p ${RPM_BUILD_ROOT}%{_sbindir}
@@ -84,22 +82,20 @@ mkdir -p ${RPM_BUILD_ROOT}/etc/xinetd.d
 install -m644 %SOURCE1 ${RPM_BUILD_ROOT}/etc/xinetd.d/talk
 install -m644 %SOURCE2 ${RPM_BUILD_ROOT}/etc/xinetd.d/ntalk
 
-%clean
-rm -rf ${RPM_BUILD_ROOT}
-
 %files
-%defattr(-,root,root,-)
 %{_bindir}/talk
 %{_mandir}/man1/*
 
 %files server
-%defattr(-,root,root,-)
 %attr(0711,root,root)%{_sbindir}/in.ntalkd
 %{_sbindir}/in.talkd
 %{_mandir}/man8/*
 %config(noreplace) /etc/xinetd.d/*
 
 %changelog
+* Mon Sep 10 2012 Vitezslav Crhonek <vcrhonek at redhat.com> - 0.17-40
+- Fix issues found by fedora-review utility in the spec file
+
 * Sat Jul 21 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.17-39
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 


More information about the scm-commits mailing list