[libreoffice/f17] Resolves: rhbz#855972 crash on switching to outline view

Caolán McNamara caolanm at fedoraproject.org
Mon Sep 10 22:05:25 UTC 2012


commit 957f91e528fef2aef8ed2b64308fe83a01800cb3
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Sep 10 23:05:05 2012 +0100

    Resolves: rhbz#855972 crash on switching to outline view

 ...bz-855972-crash-on-switching-to-outline-v.patch |   29 ++++++++++++++++++++
 libreoffice.spec                                   |    7 ++++-
 2 files changed, 35 insertions(+), 1 deletions(-)
---
diff --git a/0001-Resolves-rhbz-855972-crash-on-switching-to-outline-v.patch b/0001-Resolves-rhbz-855972-crash-on-switching-to-outline-v.patch
new file mode 100644
index 0000000..14b3fdd
--- /dev/null
+++ b/0001-Resolves-rhbz-855972-crash-on-switching-to-outline-v.patch
@@ -0,0 +1,29 @@
+From d1c1cce4ec0222ac50f9f78ddf5f4ce7aa7377ab Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Caol=C3=A1n=20McNamara?= <caolanm at redhat.com>
+Date: Mon, 10 Sep 2012 22:55:02 +0100
+Subject: [PATCH] Resolves: rhbz#855972 crash on switching to outline view
+
+Change-Id: Ic2675e9d1d8ce6bb67e9c9e4db292f79c4240409
+---
+ svx/source/form/fmvwimp.cxx | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/svx/source/form/fmvwimp.cxx b/svx/source/form/fmvwimp.cxx
+index 195b47e..638fd6e 100644
+--- a/svx/source/form/fmvwimp.cxx
++++ b/svx/source/form/fmvwimp.cxx
+@@ -938,8 +938,10 @@ IMPL_LINK(FmXFormView, OnAutoFocus, void*, /*EMPTYTAG*/)
+     do
+     {
+ 
++    SdrPageView *pPageView = m_pView ? m_pView->GetSdrPageView() : NULL;
++    SdrPage *pSdrPage = pPageView ? pPageView->GetPage() : NULL;
+     // get the forms collection of the page we belong to
+-    FmFormPage* pPage = m_pView ? PTR_CAST( FmFormPage, m_pView->GetSdrPageView()->GetPage() ) : NULL;
++    FmFormPage* pPage = PTR_CAST( FmFormPage, pSdrPage );
+     Reference< XIndexAccess > xForms( pPage ? Reference< XIndexAccess >( pPage->GetForms(), UNO_QUERY ) : Reference< XIndexAccess >() );
+ 
+     const PFormViewPageWindowAdapter pAdapter = m_aPageWindowAdapters.empty() ? NULL : m_aPageWindowAdapters[0];
+-- 
+1.7.11.4
+
diff --git a/libreoffice.spec b/libreoffice.spec
index ac0ebea..1bc15ed 100644
--- a/libreoffice.spec
+++ b/libreoffice.spec
@@ -35,7 +35,7 @@ Summary:        Free Software Productivity Suite
 Name:           libreoffice
 Epoch:          1
 Version:        %{libo_version}.2
-Release:        2%{?dist}
+Release:        3%{?dist}
 License:        (MPLv1.1 or LGPLv3+) and LGPLv3 and LGPLv2+ and BSD and (MPLv1.1 or GPLv2 or LGPLv2 or Netscape) and Public Domain and ASL 2.0 and Artistic
 Group:          Applications/Productivity
 URL:            http://www.documentfoundation.org/develop
@@ -151,6 +151,7 @@ Patch33: 0001-Resolves-rhbz-838368-view-ignored-while-view-accepte.patch
 Patch34: 0001-Resolves-rhbz-836937-insanely-slow-with-Zemberek-ins.patch
 Patch35: 0001-Resolves-rhbz-846775-Clipboard-must-be-disposed-befo.patch
 Patch36: 0001-Resolves-rhbz-842292-crash-in-calling-callback-whose.patch
+Patch37: 0001-Resolves-rhbz-855972-crash-on-switching-to-outline-v.patch
 
 %{!?python_sitearch: %global python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
 %define instdir %{_libdir}
@@ -1017,6 +1018,7 @@ mv -f redhat.soc extras/source/palettes/standard.soc
 %patch34 -p1 -b .rhbz-836937-insanely-slow-with-Zemberek-ins.patch
 %patch35 -p1 -b .rhbz-846775-Clipboard-must-be-disposed-befo.patch
 %patch36 -p1 -b .rhbz-842292-crash-in-calling-callback-whose.patch
+%patch37 -p1 -b .rhbz-855972-crash-on-switching-to-outline-v.patch
 
 # TODO: check this
 # these are horribly incomplete--empty translations and copied english
@@ -2303,6 +2305,9 @@ update-desktop-database %{_datadir}/applications &> /dev/null || :
 %endif
 
 %changelog
+* Mon Sep 10 2012 Caolán McNamara <caolanm at redhat.com> - 1:3.5.6.2-3
+- Resolves: rhbz#855972 crash on switching to outline view
+
 * Wed Aug 22 2012 Caolán McNamara <caolanm at redhat.com> - 1:3.5.6.2-2
 - Resolves: rhbz#846775 Clipboard must be disposed before Selection
 - Resolves: rhbz#842292 crash in scrolling multiselection in draw


More information about the scm-commits mailing list