[xorg-x11-server/f17] Bump default EQ size to avoid spurious abrt reports

Adam Jackson ajax at fedoraproject.org
Wed Jan 23 21:14:34 UTC 2013


commit 56f8379baf68848aa2c0114faa1327f46cc8a2c6
Author: Adam Jackson <ajax at redhat.com>
Date:   Wed Jan 23 16:14:28 2013 -0500

    Bump default EQ size to avoid spurious abrt reports

 0001-mieq-Bump-default-queue-size-to-512.patch |   43 ++++++++++++++++++++++++
 xorg-x11-server.spec                           |    7 +++-
 2 files changed, 49 insertions(+), 1 deletions(-)
---
diff --git a/0001-mieq-Bump-default-queue-size-to-512.patch b/0001-mieq-Bump-default-queue-size-to-512.patch
new file mode 100644
index 0000000..a50df5d
--- /dev/null
+++ b/0001-mieq-Bump-default-queue-size-to-512.patch
@@ -0,0 +1,43 @@
+From 2d554ab4874943a6b73132ba84835586011f2b45 Mon Sep 17 00:00:00 2001
+From: Adam Jackson <ajax at redhat.com>
+Date: Fri, 30 Nov 2012 13:50:40 -0500
+Subject: [PATCH] mieq: Bump default queue size to 512
+
+Based on some bugzilla scraping just now.  Of xserver bugs with
+attachments, the distribution looks like:
+
+String                      | Matches
+-------------------------------------
+Increasing EQ size to 512   | 460
+Increasing EQ size to 1024  | 52
+Increasing EQ size to 2048  | 6
+Increasing EQ size to 4096  | 0
+
+Most of the "512" ones appear to be mostly harmless, some relatively
+expensive path in either rendering or resource destruction simply taking
+too long due to external pressures like paging or CPU contention.  So
+let's raise the initial queue size, both to reduce the number of
+spurious abrt reports and to drop fewer events in all but the most
+pathological cases.
+
+Signed-off-by: Adam Jackson <ajax at redhat.com>
+---
+ mi/mieq.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mi/mieq.c b/mi/mieq.c
+index b2c7769..c1d845b 100644
+--- a/mi/mieq.c
++++ b/mi/mieq.c
+@@ -60,7 +60,7 @@ in this Software without prior written authorization from The Open Group.
+ #endif
+ 
+ /* Maximum size should be initial size multiplied by a power of 2 */
+-#define QUEUE_INITIAL_SIZE                 256
++#define QUEUE_INITIAL_SIZE                 512
+ #define QUEUE_RESERVED_SIZE                 64
+ #define QUEUE_MAXIMUM_SIZE                4096
+ #define QUEUE_DROP_BACKTRACE_FREQUENCY     100
+-- 
+1.7.11.7
+
diff --git a/xorg-x11-server.spec b/xorg-x11-server.spec
index 0c24438..203d6a4 100644
--- a/xorg-x11-server.spec
+++ b/xorg-x11-server.spec
@@ -48,7 +48,7 @@
 Summary:   X.Org X11 X server
 Name:      xorg-x11-server
 Version:   1.12.4
-Release:   2%{?gitdate:.%{gitdate}}%{dist}
+Release:   3%{?gitdate:.%{gitdate}}%{dist}
 URL:       http://www.x.org
 License:   MIT
 Group:     User Interface/X
@@ -118,6 +118,8 @@ Patch7021: 0001-dix-set-the-device-transformation-matrix.patch
 
 Patch7022: 0001-Touch-Fix-duplicate-TouchBegin-selection-with-virtua.patch
 
+Patch7023: 0001-mieq-Bump-default-queue-size-to-512.patch
+
 %define moduledir	%{_libdir}/xorg/modules
 %define drimoduledir	%{_libdir}/dri
 %define sdkdir		%{_includedir}/xorg
@@ -586,6 +588,9 @@ rm -rf $RPM_BUILD_ROOT
 %{xserver_source_dir}
 
 %changelog
+* Wed Jan 23 2013 Adam Jackson <ajax at redhat.com> 1.12.4-3
+- Bump default EQ size to avoid spurious abrt reports
+
 * Fri Dec 14 2012 Adam Jackson <ajax at redhat.com> 1.12.4-2
 - Cherry-pick a fix for selection for TouchBegin from multiple clients
 


More information about the scm-commits mailing list