[fedora-review] Add patch to fix fedora-create-review and bump release

Pierre-YvesChibon pingou at fedoraproject.org
Mon Feb 4 20:41:16 UTC 2013


commit c2e099b94ee8f0470b5142945249a6a14e7bc14e
Author: Pierre-Yves Chibon <pingou at pingoured.fr>
Date:   Mon Feb 4 21:39:43 2013 +0100

    Add patch to fix fedora-create-review and bump release

 0001-Fix-syntax-error.patch |   26 ++++++++++++++++++++++++++
 fedora-review.spec          |    8 +++++++-
 2 files changed, 33 insertions(+), 1 deletions(-)
---
diff --git a/0001-Fix-syntax-error.patch b/0001-Fix-syntax-error.patch
new file mode 100644
index 0000000..e8dbf12
--- /dev/null
+++ b/0001-Fix-syntax-error.patch
@@ -0,0 +1,26 @@
+From 5aee7f3fcccf74a8f11b658d8ed047e104be3170 Mon Sep 17 00:00:00 2001
+From: Ralph Bean <rbean at redhat.com>
+Date: Sun, 3 Feb 2013 14:31:21 -0500
+Subject: [PATCH 1/7] Fix syntax error.
+
+Signed-off-by: Alec Leamas <leamas.alec at gmail.com>
+---
+ src/fedora-create-review |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/src/fedora-create-review b/src/fedora-create-review
+index c7ef834..ed8fba3 100755
+--- a/src/fedora-create-review
++++ b/src/fedora-create-review
+@@ -277,7 +277,7 @@ class ReviewRequest(object):
+             bzurl = 'https://partner-bugzilla.redhat.com'
+ 
+         self.username = args.username
+-        if not self.username
++        if not self.username:
+             try:
+                 self.username = fedora_cert.read_user_cert()
+             except:
+-- 
+1.7.1
+
diff --git a/fedora-review.spec b/fedora-review.spec
index ea8b09c..78482da 100644
--- a/fedora-review.spec
+++ b/fedora-review.spec
@@ -6,7 +6,7 @@
 
 Name:       fedora-review
 Version:    0.4.0
-Release:    1%{?git_tag}%{?dist}
+Release:    2%{?git_tag}%{?dist}
 Summary:    Review tool for fedora rpm packages
 
 License:    GPLv2+
@@ -34,6 +34,8 @@ Requires:       python-argparse
 # Let's be consistent with the name used on fedorahosted
 provides:       FedoraReview = %{version}-%{release}
 
+# Applied upstream - 5aee7f3
+Patch0:        0001-Fix-syntax-error.patch
 
 %description
 This tool automates much of the dirty work when reviewing a package
@@ -74,6 +76,7 @@ see http://php5.laurent-laville.org/compatinfo/.
 %prep
 %setup -q
 
+%patch0 -p1 -b .
 
 %build
 %{__python} setup.py --quiet build
@@ -125,6 +128,9 @@ python -m unittest discover -f
 
 
 %changelog
+* Mon Feb 04 2013 Pierre-Yves Chibon <pingou at pingoured.fr> - 0.4.0-2
+- Add Patch0 (0001-Fix-syntax-error.patch) from Ralph Bean fixing fedora-create-review
+
 * Mon Jan 28 2013 Stanislav Ochotnicky <sochotnicky at redhat.com> - 0.4.0-1
 - Updating to upstream 0.4.0
 


More information about the scm-commits mailing list