[soundconverter] Disable "Remove" temporarily, since it's completely broken.

Michael Schwendt mschwendt at fedoraproject.org
Wed Feb 13 13:23:54 UTC 2013


commit 72e1a5fd83aa9cbd8f483c77ec2785d3c66fe276
Author: Michael Schwendt <mschwendt at fedoraproject.org>
Date:   Wed Feb 13 14:23:50 2013 +0100

    Disable "Remove" temporarily, since it's completely broken.
    
    - Fix GtkWarning about drag-data-received.

 ...onverter-2.0.4-drag-data-received-warning.patch |   11 +++++++++++
 soundconverter-2.0.4-remove-is-broken.patch        |   11 +++++++++++
 soundconverter.spec                                |   12 +++++++++++-
 3 files changed, 33 insertions(+), 1 deletions(-)
---
diff --git a/soundconverter-2.0.4-drag-data-received-warning.patch b/soundconverter-2.0.4-drag-data-received-warning.patch
new file mode 100644
index 0000000..c123c37
--- /dev/null
+++ b/soundconverter-2.0.4-drag-data-received-warning.patch
@@ -0,0 +1,11 @@
+diff -Nur soundconverter-2.0.4-orig/soundconverter/ui.py soundconverter-2.0.4/soundconverter/ui.py
+--- soundconverter-2.0.4-orig/soundconverter/ui.py	2012-10-06 12:43:23.000000000 +0200
++++ soundconverter-2.0.4/soundconverter/ui.py	2013-02-13 12:18:55.879641622 +0100
+@@ -177,6 +177,7 @@
+     def drag_data_received(self, widget, context, x, y, selection,
+                              mime_id, time):
+ 
++        widget.stop_emission('drag_data_received')
+         if mime_id >= 0 and mime_id < len(self.drop_mime_types):
+             self.add_uris([uri.strip() for uri in selection.data.split('\n')])
+             context.finish(True, False, time)
diff --git a/soundconverter-2.0.4-remove-is-broken.patch b/soundconverter-2.0.4-remove-is-broken.patch
new file mode 100644
index 0000000..e5adde3
--- /dev/null
+++ b/soundconverter-2.0.4-remove-is-broken.patch
@@ -0,0 +1,11 @@
+diff -Nur soundconverter-2.0.4-orig/soundconverter/ui.py soundconverter-2.0.4/soundconverter/ui.py
+--- soundconverter-2.0.4-orig/soundconverter/ui.py	2012-10-06 12:43:23.000000000 +0200
++++ soundconverter-2.0.4/soundconverter/ui.py	2013-02-13 14:19:48.106712576 +0100
+@@ -1285,6 +1285,7 @@
+         self.set_sensitive()
+ 
+     def on_remove_activate(self, *args):
++        return
+         model, paths = self.filelist_selection.get_selected_rows()
+         while paths:
+             i = self.filelist.model.get_iter(paths[0])
diff --git a/soundconverter.spec b/soundconverter.spec
index b78d44c..97d22fd 100644
--- a/soundconverter.spec
+++ b/soundconverter.spec
@@ -2,7 +2,7 @@
 
 Name:           soundconverter
 Version:        2.0.4
-Release:        13%{?dist}
+Release:        14%{?dist}
 Summary:        Simple sound converter application for GNOME
 
 Group:          Applications/Multimedia
@@ -30,6 +30,10 @@ Patch6: soundconverter-2.0.4-gst-pipeline.patch
 Patch7: soundconverter-2.0.4-gst-install-abort.patch
 # reported, lp #1123957
 Patch8: soundconverter-2.0.4-no-gnome-audio-profiles.patch
+# reported, lp #1123957
+Patch9: soundconverter-2.0.4-drag-data-received-warning.patch
+# reported, lp #1123519
+Patch10: soundconverter-2.0.4-remove-is-broken.patch
 
 BuildRequires:  desktop-file-utils
 BuildRequires:  intltool gettext
@@ -77,6 +81,8 @@ writes anything the GStreamer library can.
 %patch6 -p1 -b .gst-pipeline
 %patch7 -p1 -F3 -b .gst-install-abort
 %patch8 -p1 -b .no-gnome-audio-profiles
+%patch9 -p1 -b .drag-data-received-warning
+%patch10 -p1 -b .disable-remove
 
 
 %build
@@ -130,6 +136,10 @@ update-desktop-database &> /dev/null ||:
 
 
 %changelog
+* Wed Feb 13 2013 Michael Schwendt <mschwendt at fedoraproject.org> - 2.0.4-14
+- Disable "Remove" temporarily, since it's completely broken.
+- Fix GtkWarning about drag-data-received.
+
 * Wed Feb 13 2013 Michael Schwendt <mschwendt at fedoraproject.org> - 2.0.4-13
 - Disable "GNOME Audio Profile" encoder, if no audio profiles are found
   (#910613).


More information about the scm-commits mailing list