[soundconverter] Fix "Remove" to use gtk.TreeModelSort.convert_path_to_child_path

Michael Schwendt mschwendt at fedoraproject.org
Wed Feb 13 14:06:45 UTC 2013


commit 46183bc59022672ac4a46b98d6977ecf727f2f10
Author: Michael Schwendt <mschwendt at fedoraproject.org>
Date:   Wed Feb 13 15:06:39 2013 +0100

    Fix "Remove" to use gtk.TreeModelSort.convert_path_to_child_path

 soundconverter-2.0.4-remove-is-broken.patch       |   11 -----------
 soundconverter-2.0.4-remove-treesortedmodel.patch |   13 +++++++++++++
 soundconverter.spec                               |    7 +++++--
 3 files changed, 18 insertions(+), 13 deletions(-)
---
diff --git a/soundconverter-2.0.4-remove-treesortedmodel.patch b/soundconverter-2.0.4-remove-treesortedmodel.patch
new file mode 100644
index 0000000..6a47277
--- /dev/null
+++ b/soundconverter-2.0.4-remove-treesortedmodel.patch
@@ -0,0 +1,13 @@
+diff -Nur soundconverter-2.0.4-orig/soundconverter/ui.py soundconverter-2.0.4/soundconverter/ui.py
+--- soundconverter-2.0.4-orig/soundconverter/ui.py	2012-10-06 12:43:23.000000000 +0200
++++ soundconverter-2.0.4/soundconverter/ui.py	2013-02-13 15:02:46.579234935 +0100
+@@ -1287,7 +1287,8 @@
+     def on_remove_activate(self, *args):
+         model, paths = self.filelist_selection.get_selected_rows()
+         while paths:
+-            i = self.filelist.model.get_iter(paths[0])
++            childpath = model.convert_path_to_child_path(paths[0])
++            i = self.filelist.model.get_iter(childpath)
+             self.filelist.remove(i)
+             model, paths = self.filelist_selection.get_selected_rows()
+         self.set_sensitive()
diff --git a/soundconverter.spec b/soundconverter.spec
index 97d22fd..f320c88 100644
--- a/soundconverter.spec
+++ b/soundconverter.spec
@@ -2,7 +2,7 @@
 
 Name:           soundconverter
 Version:        2.0.4
-Release:        14%{?dist}
+Release:        15%{?dist}
 Summary:        Simple sound converter application for GNOME
 
 Group:          Applications/Multimedia
@@ -33,7 +33,7 @@ Patch8: soundconverter-2.0.4-no-gnome-audio-profiles.patch
 # reported, lp #1123957
 Patch9: soundconverter-2.0.4-drag-data-received-warning.patch
 # reported, lp #1123519
-Patch10: soundconverter-2.0.4-remove-is-broken.patch
+Patch10: soundconverter-2.0.4-remove-treesortedmodel.patch
 
 BuildRequires:  desktop-file-utils
 BuildRequires:  intltool gettext
@@ -136,6 +136,9 @@ update-desktop-database &> /dev/null ||:
 
 
 %changelog
+* Wed Feb 13 2013 Michael Schwendt <mschwendt at fedoraproject.org> - 2.0.4-15
+- Fix "Remove" to use gtk.TreeModelSort.convert_path_to_child_path
+
 * Wed Feb 13 2013 Michael Schwendt <mschwendt at fedoraproject.org> - 2.0.4-14
 - Disable "Remove" temporarily, since it's completely broken.
 - Fix GtkWarning about drag-data-received.


More information about the scm-commits mailing list