commit 0a8b916997f3115ab82085beaf864c494b0824df
Author: Orcan Ogetbil <oget.fedora at gmail.com>
Date: Sat Feb 23 12:26:00 2013 -0500
Bugfix: occasional crash due to uninitialized pointer. RHBZ #914659
deco-uninitialized-ptr-crash.patch | 11 +++++++++++
deco.spec | 15 ++++++++-------
2 files changed, 19 insertions(+), 7 deletions(-)
---
diff --git a/deco-uninitialized-ptr-crash.patch b/deco-uninitialized-ptr-crash.patch
new file mode 100644
index 0000000..7531888
--- /dev/null
+++ b/deco-uninitialized-ptr-crash.patch
@@ -0,0 +1,11 @@
+diff -rupN deco-1.6.2.old/arch.c deco-1.6.2/arch.c
+--- deco-1.6.2.old/arch.c 2010-06-07 14:31:24.000000000 -0400
++++ deco-1.6.2/arch.c 2013-02-23 11:43:53.899624737 -0500
+@@ -164,6 +164,7 @@ static bool handle_contents(const struct
+ char *moved;
+ unsigned int entries = 0;
+
++ first.p = first.e = first.z = NULL;
+ dir = open_dir(a->sandbox.p);
+ if (!dir)
+ return false;
diff --git a/deco.spec b/deco.spec
index 8894b8b..f2a63aa 100644
--- a/deco.spec
+++ b/deco.spec
@@ -1,12 +1,14 @@
Name: deco
Version: 1.6.2
-Release: 5%{?dist}
+Release: 6%{?dist}
Summary: Extractor for various archive file formats
Group: Applications/Archiving
License: GPLv3
URL: http://hartlich.com/deco/
Source0: http://hartlich.com/deco/download/%{name}-%{version}.tar.gz
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+# Crash on freeing uninitialized pointer. RHBZ #914659
+# Patch sent upstream via email
+Patch0: deco-uninitialized-ptr-crash.patch
Requires: deco-archive >= 1.2
@@ -18,26 +20,25 @@ interface and much more.
%prep
%setup -q
+%patch0 -p1 -b .initptr
%build
make %{?_smp_mflags} PREFIX=%{_prefix} SHARE=%{_var}/lib/%{name} \
CFLAGS="%optflags" LDFLAGS=""
%install
-rm -rf %{buildroot}
make install PREFIX=%{_prefix} DESTDIR=%{buildroot}
install -dm 755 %{buildroot}/%{_var}/lib/%{name}
-%clean
-rm -rf %{buildroot}
-
%files
-%defattr(-,root,root,-)
%doc LICENSE CREDITS NEWS README
%{_bindir}/%{name}
%dir %{_var}/lib/%{name}
%changelog
+* Sat Feb 23 2013 Orcan Ogetbil <oget [DOT] fedora [AT] gmail [DOT] com> 1.6.2-6
+- Bugfix: occasional crash due to uninitialized pointer. RHBZ #914659
+
* Wed Feb 13 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.6.2-5
- Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild