[python-feedparser] Add BuildRequires/Requires python-chardet because if it's installed
Michael Schwendt
mschwendt at fedoraproject.org
Sat Mar 9 13:37:09 UTC 2013
commit feab52ce0e58286f721e7357daadb0df1e6862b1
Author: Michael Schwendt <mschwendt at fedoraproject.org>
Date: Sat Mar 9 14:37:03 2013 +0100
Add BuildRequires/Requires python-chardet because if it's installed
as a dependency of other Python module packages, it would be imported
and used anyway, and it doesn't make any tests fail.
python-feedparser.spec | 16 ++++++++++++++--
1 files changed, 14 insertions(+), 2 deletions(-)
---
diff --git a/python-feedparser.spec b/python-feedparser.spec
index e0b7ef5..548b7a8 100644
--- a/python-feedparser.spec
+++ b/python-feedparser.spec
@@ -8,7 +8,7 @@
Name: python-feedparser
Version: 5.1.3
-Release: 1%{?dist}
+Release: 2%{?dist}
Summary: Parse RSS and Atom feeds in Python
Group: Development/Languages
@@ -22,14 +22,21 @@ BuildArch: noarch
BuildRequires: python-devel
BuildRequires: python-setuptools
+# optional import at run-time, but is likely installed because other
+# python module packages depend on it, too
+# no failing tests on 2013-03-09 with python-chardet-2.0.1
+BuildRequires: python-chardet
+Requires: python-chardet
+
## TODO: Decide on these, also with regard to explicit "Requires".
## Optional imports at run-time and influence the test-suite, too,
## and causes additional tests to fail.
#BuildRequires: python-BeautifulSoup
-#BuildRequires: python-chardet
## the preferred XML parser
#BuildRequires: libxml2-python
+## TODO: python3-chardet BR and Req
+
# shows that for Python 3 the test-suite fails early with
# ImportError: No module named 'BaseHTTPServer'
Patch0: feedparser-5.1.3-tests-py3.patch
@@ -119,6 +126,11 @@ rm -rf %{buildroot}
%changelog
+* Sat Mar 9 2013 Michael Schwendt <mschwendt at fedoraproject.org> - 5.1.3-2
+- Add BuildRequires/Requires python-chardet because if it's installed
+ as a dependency of other Python module packages, it would be imported
+ and used anyway, and it doesn't make any tests fail.
+
* Sat Mar 9 2013 Michael Schwendt <mschwendt at fedoraproject.org> - 5.1.3-1
- Update to 5.1.3 (50k diff).
- Patch test-suite minimally for python3 to show that it fails early.
More information about the scm-commits
mailing list