[slic3r/f17] Added back in-line comment about the patch

Miro Hrončok churchyard at fedoraproject.org
Wed Apr 3 14:19:10 UTC 2013


commit af9a073aa4517f9e2d5f61d58a5cdf97b2cbc817
Author: Miro Hrončok <miro at hroncok.cz>
Date:   Wed Apr 3 16:18:52 2013 +0200

    Added back in-line comment about the patch

 slic3r-english-locale.patch |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)
---
diff --git a/slic3r-english-locale.patch b/slic3r-english-locale.patch
index 777d64b..cf713f8 100644
--- a/slic3r-english-locale.patch
+++ b/slic3r-english-locale.patch
@@ -1,3 +1,14 @@
+Upstream constantly refuses to support Perl >= 5.16.
+They say it handles locales incorrectly, but it might be caused by bad code
+design. Running Slic3r with locales using other char than point as a decimal
+separator causes crashes. This patch removes the warning about unsupported
+Perl version (it is very annoying) and forces Slic3r to use English decimal
+separator by setting the LC_NUMERIC environment variable. Setting it in more
+Perl way doesn't work and is overwritten in some of imported modules.
+https://github.com/alexrj/Slic3r/issues/935
+https://github.com/alexrj/Slic3r/pull/936#issuecomment-12544383
+https://github.com/alexrj/Slic3r/issues/538#issuecomment-14560494
+
 diff -ruN b/lib/Slic3r.pm c/lib/Slic3r.pm
 --- b/lib/Slic3r.pm	2013-03-29 18:45:49.274139014 +0100
 +++ c/lib/Slic3r.pm	2013-03-29 18:47:04.673085095 +0100


More information about the scm-commits mailing list