[perl-Dancer/f18] Return proper exit code on dancer tool failure

Petr Pisar ppisar at fedoraproject.org
Tue May 7 14:19:03 UTC 2013


commit 1c843d1e83085e1a38cb2a85ad3f9fda3c2e4fec
Author: Petr Písař <ppisar at redhat.com>
Date:   Tue May 7 15:56:33 2013 +0200

    Return proper exit code on dancer tool failure

 ...on-zero-exit-code-on-bad-application-name.patch |   25 ++++++++++++++++++++
 perl-Dancer.spec                                   |    8 +++++-
 2 files changed, 32 insertions(+), 1 deletions(-)
---
diff --git a/Dancer-1.3112-Return-non-zero-exit-code-on-bad-application-name.patch b/Dancer-1.3112-Return-non-zero-exit-code-on-bad-application-name.patch
new file mode 100644
index 0000000..ea680df
--- /dev/null
+++ b/Dancer-1.3112-Return-non-zero-exit-code-on-bad-application-name.patch
@@ -0,0 +1,25 @@
+From 2cd69b0b5b1e31fcaa0306844c61bffb24a7253a Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar at redhat.com>
+Date: Tue, 7 May 2013 15:44:52 +0200
+Subject: [PATCH] Return non-zero exit code on bad application name
+
+---
+ script/dancer | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/script/dancer b/script/dancer
+index eb63000..1561315 100755
+--- a/script/dancer
++++ b/script/dancer
+@@ -80,7 +80,7 @@ sub validate_app_name {
+         print STDERR "Error: Invalid application name.\n";
+         print STDERR "Application names must not contain single colons,"
+             ." dots, hyphens or start with a number.\n";
+-        exit;
++        exit 1;
+     }
+ }
+ 
+-- 
+1.8.1.4
+
diff --git a/perl-Dancer.spec b/perl-Dancer.spec
index 355f25d..cd682ca 100644
--- a/perl-Dancer.spec
+++ b/perl-Dancer.spec
@@ -1,11 +1,13 @@
 Name:           perl-Dancer
 Version:        1.3100
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        Lightweight yet powerful web application framework
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Dancer/
 Source0:        http://www.cpan.org/authors/id/X/XS/XSAWYERX/Dancer-%{version}.tar.gz
+# Bug #960184, GitHub #PerlDancer/Dancer/919
+Patch0:         Dancer-1.3112-Return-non-zero-exit-code-on-bad-application-name.patch
 BuildArch:      noarch
 BuildRequires:  perl(base)
 BuildRequires:  perl(Carp)
@@ -85,6 +87,7 @@ your code.
 
 %prep
 %setup -q -n Dancer-%{version}
+%patch0 -p1
 
 %build
 perl Makefile.PL INSTALLDIRS=vendor
@@ -107,6 +110,9 @@ make test
 %{_mandir}/man3/*
 
 %changelog
+* Tue May 07 2013 Petr Pisar <ppisar at redhat.com> - 1.3112-2
+- Return proper exit code on dancer tool failure (bug #960184)
+
 * Mon Aug 27 2012 Petr Šabata <contyk at redhat.com> - 1.3100-1
 - 1.3100 bump
 


More information about the scm-commits mailing list