[kexec-tools] rawdump: only show dd progress bar when core_collector is not makedumpfile

Baoquan He baoquan at fedoraproject.org
Tue Jun 25 08:53:43 UTC 2013


commit 315848036bee4397873642c54fa794afe341e3b1
Author: Baoquan He <bhe at redhat.com>
Date:   Tue Jun 25 16:40:43 2013 +0800

    rawdump: only show dd progress bar when core_collector is not makedumpfile
    
    When using makedumpfile as core_collector, makedumpfile will show its
    own progress bar, it will mix with the monitor_dd_progress and cause confusion.
    In this patch just call monitor_dd_progress when core_collector is not
    makedumpfile
    
    Signed-off-by: Dave Young <dyoung at redhat.com>
    Acked-by: WANG Chao <chaowang at redhat.com>

 dracut-kdump.sh |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/dracut-kdump.sh b/dracut-kdump.sh
index e7dadcb..c648bb2 100755
--- a/dracut-kdump.sh
+++ b/dracut-kdump.sh
@@ -102,15 +102,12 @@ dump_raw()
 
     echo "kdump: saving to raw disk $_raw"
 
-    if $(echo -n $CORE_COLLECTOR|grep -q makedumpfile); then
-        _src_size_mb="Unknown"
-    else
+    if ! $(echo -n $CORE_COLLECTOR|grep -q makedumpfile); then
         _src_size=`ls -l /proc/vmcore | cut -d' ' -f5`
         _src_size_mb=$(($_src_size / 1048576))
+        monitor_dd_progress $_src_size_mb &
     fi
 
-    monitor_dd_progress $_src_size_mb &
-
     echo "kdump: saving vmcore"
     $CORE_COLLECTOR /proc/vmcore | dd of=$_raw bs=$DD_BLKSIZE >> /tmp/dd_progress_file 2>&1 || return 1
 


More information about the scm-commits mailing list