[cacti] rpmlint fixes

Ken Dreyer ktdreyer at fedoraproject.org
Sun Jul 14 21:58:17 UTC 2013


commit 679597de718af1ca8f4f8678d192adf1ecf7bf1f
Author: Ken Dreyer <ktdreyer at ktdreyer.com>
Date:   Sun Jul 14 15:43:07 2013 -0600

    rpmlint fixes
    
    - Remove macros from comments
    - Add empty %build
    - Trim changelog (removes several bogus calendar dates)

 cacti.spec |   94 ++---------------------------------------------------------
 1 files changed, 4 insertions(+), 90 deletions(-)
---
diff --git a/cacti.spec b/cacti.spec
index dab2182..861635e 100644
--- a/cacti.spec
+++ b/cacti.spec
@@ -7,7 +7,7 @@ Group: Applications/System
 # There's a lot of stuff in there. It's all compatible.
 License: GPLv2+ and LGPLv2 and (MPLv1.1 or GPLv2 or LGPLv2) and (LGPLv2 or BSD)
 URL: http://www.cacti.net/
-# Source0: http://www.cacti.net/downloads/%{name}-%{version}.tar.gz
+# Source0: http://www.cacti.net/downloads/%%{name}-%%{version}.tar.gz
 # Just unpack, rm -rf include/treeview/* , then	repack.
 Source0: %{name}-%{version}-notreeview.tar.gz
 Source1: cacti-httpd.conf
@@ -47,6 +47,9 @@ rm -rf include/treeview
 
 echo "#*/5 * * * *	cacti	%{_bindir}/php %{_datadir}/%{name}/poller.php > /dev/null 2>&1" >cacti.cron
 
+%build
+# cacti's build is a noop
+
 %install
 rm -rf %{buildroot}
 %{__mkdir} -p %{buildroot}/%{_sysconfdir}/%{name}
@@ -242,92 +245,3 @@ fi
 * Tue Nov 20 2007 Mike McGrath <mmcgrath at redhat.com> - 0.8.7a-1
 - Upstream released new version
 - Fixes for bug #391691 - CVE-2007-6035
-
-* Fri Oct 13 2007 Mike McGrath <mmcgrath at redhat.com> - 0.8.7-2
-- Upstream released new version
-- No longer need to patch for /etc/cacti/*
-
-* Fri Sep 14 2007 Mike McGrath <mmcgrath at redhat.com> - 0.8.6j-8
-- Fix for CVE-2007-3112 bz#243592
-
-* Sat Sep 08 2007 Mike McGrath <mmcgrath at redhat.com> - 0.8.6j-6
-- rebuild
-
-* Sat May 05 2007 Mike McGrath <mmcgrath at redhat.com> - 0.8.6j-5
-- Upstream released new version
-
-* Fri Jan 12 2007 Mike McGrath <imlinux at gmail.com> - 0.8.6i-5
-- Added 4 upstream patches
-- Fix for BZ 222410
-
-* Thu Nov 09 2006 Mike McGrath <imlinux at gmail.com> - 0.8.6i-4
-- Patch now includes <?php BG# 214914
-
-* Thu Sep 07 2006 Mike McGrath <imlinux at gmail.com> - 0.8.6i-3
-- Upstream released new version
-
-* Thu Sep 07 2006 Mike McGrath <imlinux at gmail.com> - 0.8.6i-2
-- Upstream released new version
-
-* Thu Sep 07 2006 Mike McGrath <imlinux at gmail.com> - 0.8.6h-7
-- Mass rebuild
-
-* Wed Feb 22 2006 Mike McGrath <imlinux at gmail.com> - 0.8.6h-6
-- Disabled Cron job by default
-
-* Tue Feb 14 2006 Mike McGrath <imlinux at gmail.com> - 0.8.6h-5
-- Rebuild for Fedora Extras 5
-
-* Mon Feb 6 2006 Mike McGrath <imlinux at gmail.com> - 0.8.6h-4
-- Fixed some scriptlets to always return 0
-- Fixed extra '/' in logrotate
-- Added README.Fedora
-
-* Wed Jan 14 2006 Mike McGrath <imlinux at gmail.com> - 0.8.6h-3
-- Fixed device filter clear issue
-- Fixed invalid SQL graph generation statement
-- Fixed php warning for empty set non-existant rrd file
-- Added MySQL 5.x 'strict mode' compatibility
-
-* Mon Jan 09 2006 Mike McGrath <imlinux at gmail.com> - 0.8.6h-1
-- MySQL 5.x support
-- IPv6 support to lib/ping.php
-- Command line scripts for copying users, reindxing and rebuilding cache
-- Many Bug fixes
-
-* Tue Dec 18 2005 Mike McGrath <imlinux at gmail.com> - 0.8.6g-7
-- Separated database configs from config.php
-- Fixed the 'short_open_tag" syntax error
-- Fixed graph zoom graph bug
-- Fixed SNMP auth bug
-- Re-enables MIB file parsing in poller
-- Created a Fedora frendly version of the RPM
-
-* Wed Sep 7 2005 Ian Berry <iberry at raxnet.net> - 0.8.6g-1
-- Updated to release 0.8.6g.
-
-* Mon Jul 1 2005 Ian Berry <iberry at raxnet.net> - 0.8.6f-1
-- Updated to release 0.8.6f.
-
-* Mon Jun 20 2005 Ian Berry <iberry at raxnet.net> - 0.8.6e-1
-- Updated to release 0.8.6e.
-
-* Wed Apr 26 2005 Ian Berry <iberry at raxnet.net> - 0.8.6d-1
-- Updated to release 0.8.6d.
-
-* Wed Dec 12 2004 Ian Berry <iberry at raxnet.net> - 0.8.6c-1
-- Updated to release 0.8.6c.
-
-* Wed Oct 5 2004 Ian Berry <iberry at raxnet.net> - 0.8.6b-1
-- Updated to release 0.8.6b.
-
-* Sun Oct 3 2004 Ian Berry <iberry at raxnet.net> - 0.8.6a-1
-- Updated to release 0.8.6a.
-
-* Sat Sep 11 2004 Ian Berry <iberry at raxnet.net> - 0.8.6-1
-- Updated to release 0.8.6.
-- Broke cactid into its own package.
-
-* Thu Apr 4 2004 Ian Berry <iberry at raxnet.net> - 0.8.5a-1
-- Initial package.
-


More information about the scm-commits mailing list