[dnssec-trigger/f19] Fix errors found by static analysis of source

[Tomas Hozza]

commit cc334b22214cfa2ac7ff604acd7c286fe1a1318d
Author: Tomas Hozza <thozza at redhat.com>
Date:   Mon Aug 26 16:09:16 2013 +0200

    Fix errors found by static analysis of source
    
    Signed-off-by: Tomas Hozza <thozza at redhat.com>

 dnssec-trigger-0.11-coverity_scan.patch |   39 +++++++++++++++++++++++++++++++
 dnssec-trigger.spec                     |    8 +++++-
 2 files changed, 46 insertions(+), 1 deletions(-)
---
diff --git a/dnssec-trigger-0.11-coverity_scan.patch b/dnssec-trigger-0.11-coverity_scan.patch
new file mode 100644
index 0000000..30a70e3
--- /dev/null
+++ b/dnssec-trigger-0.11-coverity_scan.patch
@@ -0,0 +1,39 @@
+From b6e3deeef71a78c575d6e169d007956c02abc5da Mon Sep 17 00:00:00 2001
+From: wouter <wouter at 14dc9c71-5cc2-e011-b339-0019d10b89f4>
+Date: Mon, 26 Aug 2013 08:41:03 +0000
+Subject: [PATCH] - Fix#522: Errors found by static analysis of source from
+ Tomas Hozza.
+
+git-svn-id: http://www.nlnetlabs.nl/svn/dnssec-trigger/trunk@649 14dc9c71-5cc2-e011-b339-0019d10b89f4
+---
+ riggerd/riggerd.c | 1 +
+ riggerd/update.c  | 1 +
+ 2 files changed, 2 insertions(+)
+
+diff --git a/riggerd/riggerd.c b/riggerd/riggerd.c
+index dc61216..ef46691 100644
+--- a/riggerd/riggerd.c
++++ b/riggerd/riggerd.c
+@@ -110,6 +110,7 @@ static RETSIGTYPE record_sigh(int sig)
+ #ifdef SIGHUP
+ 	case SIGHUP:
+ 		sig_reload = 1;
++		/* fall through and exit commbase with reload boolean set */
+ #endif
+ 	case SIGTERM:
+ #ifdef SIGQUIT
+diff --git a/riggerd/update.c b/riggerd/update.c
+index 437f981..dff5380 100644
+--- a/riggerd/update.c
++++ b/riggerd/update.c
+@@ -573,6 +573,7 @@ selfupdate_write_file(struct selfupdate* se, struct http_get* hg)
+ 		out)) {
+ 		log_err("cannot write to file %s: %s", se->download_file,
+ 			strerror(errno));
++		fclose(out);
+ 		goto fail;
+ 	}
+ 	fclose(out);
+-- 
+1.8.3.1
+
diff --git a/dnssec-trigger.spec b/dnssec-trigger.spec
index 1832bb7..767e29f 100644
--- a/dnssec-trigger.spec
+++ b/dnssec-trigger.spec
@@ -1,7 +1,7 @@
 Summary: NetworkManager plugin to update/reconfigure DNSSEC resolving
 Name: dnssec-trigger
 Version: 0.11
-Release: 12%{?dist}
+Release: 13%{?dist}
 License: BSD
 Url: http://www.nlnetlabs.nl/downloads/dnssec-trigger/
 Source: http://www.nlnetlabs.nl/downloads/dnssec-trigger/%{name}-%{version}.tar.gz
@@ -16,6 +16,8 @@ Patch1: dnssec-trigger-0.11-gui.patch
 Patch2: dnssec-trigger-842455.patch
 # https://www.nlnetlabs.nl/bugs-script/show_bug.cgi?id=489
 Patch3: dnssec-trigger-0.11-nl489.patch
+Patch4: dnssec-trigger-0.11-coverity_scan.patch
+
 Requires(postun): initscripts
 Requires: ldns >= 1.6.10, NetworkManager, unbound, xdg-utils
 Requires(pre): shadow-utils
@@ -45,6 +47,7 @@ sed -i "s/^dnssec-trigger-control/\/usr\/sbin\/dnssec-trigger-control/" 01-dnsse
 %patch1 -p1
 %patch2 -p1
 %patch3 -p1
+%patch4 -p1
 
 %build
 export LDFLAGS="$LDFLAGS -Wl,-z,now"
@@ -127,6 +130,9 @@ fi
     /bin/systemctl daemon-reload >/dev/null 2>&1 || :
 
 %changelog
+* Mon Aug 26 2013 Tomas Hozza <thozza at redhat.com> - 0.11-13
+- Fix errors found by static analysis of source
+
 * Fri Aug 09 2013 Tomas Hozza <thozza at redhat.com> - 0.11-12
 - Use improved NM dispatcher script from upstream
 - Added tmpfiles.d config due to improved NM dispatcher script