[perl-Data-TreeDumper] Modernize spec; Specify all deps; Fixed BZ #994030

Jitka Plesnikova jplesnik at fedoraproject.org
Wed Aug 28 13:32:18 UTC 2013


commit a4911c9d6c149e9e622e17134e0e31b8cf383f02
Author: Jitka Plesnikova <jplesnik at redhat.com>
Date:   Wed Aug 28 15:32:03 2013 +0200

    Modernize spec; Specify all deps; Fixed BZ #994030

 perl-Data-TreeDumper.spec |   51 ++++++++++++++++----------------------------
 1 files changed, 19 insertions(+), 32 deletions(-)
---
diff --git a/perl-Data-TreeDumper.spec b/perl-Data-TreeDumper.spec
index 292ed4e..2f19284 100644
--- a/perl-Data-TreeDumper.spec
+++ b/perl-Data-TreeDumper.spec
@@ -1,23 +1,27 @@
 Name:       perl-Data-TreeDumper 
 Version:    0.40 
-Release:    5%{?dist}
+Release:    6%{?dist}
 # see TreeDumper.pm
 License:    GPL+ or Artistic
 Group:      Development/Libraries
 Summary:    Improved replacement for Data::Dumper
 Source:     http://search.cpan.org/CPAN/authors/id/N/NK/NKH/Data-TreeDumper-%{version}.tar.gz 
 Url:        http://search.cpan.org/dist/Data-TreeDumper
-BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) 
-Requires:   perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))
+Requires:   perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))
 BuildArch:  noarch
 
-BuildRequires: perl(ExtUtils::MakeMaker) 
+BuildRequires: perl 
+BuildRequires: perl(Carp)
 BuildRequires: perl(Check::ISA)
 BuildRequires: perl(Class::ISA)
 BuildRequires: perl(Devel::Size) >= 0.58
+BuildRequires: perl(Exporter) 
+BuildRequires: perl(ExtUtils::MakeMaker) 
 BuildRequires: perl(Sort::Naturally)
+BuildRequires: perl(strict)
 BuildRequires: perl(Term::Size) >= 0.2
 BuildRequires: perl(Text::Wrap) >= 2001.0929
+BuildRequires: perl(warnings)
 
 # not automagically picked up
 Requires: perl(Term::Size) >= 0.2
@@ -35,35 +39,13 @@ format more easily understood.
 %prep
 %setup -q -n Data-TreeDumper-%{version}
 
-# F-11 appears to be more sensitive to bits in _docdir.  grr. see RHBZ#473874
-cat << \EOF > %{name}-prov
-#!/bin/sh
-%{__perl_provides} `perl -p -e 's|\S+%{_docdir}/%{name}-%{version}\S+||'`
-EOF
-
-%define __perl_provides %{_builddir}/Data-TreeDumper-%{version}/%{name}-prov
-chmod +x %{__perl_provides}
-
-cat << \EOF > %{name}-req
-#!/bin/sh
-%{__perl_requires} `perl -p -e 's|\S+%{_docdir}/%{name}-%{version}\S+||'`
-EOF
-
-%define __perl_requires %{_builddir}/Data-TreeDumper-%{version}/%{name}-req
-chmod +x %{__perl_requires}
-
-
 %build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+perl Makefile.PL INSTALLDIRS=vendor
 make %{?_smp_mflags}
 
 %install
-rm -rf %{buildroot}
-
-make pure_install PERL_INSTALL_ROOT=%{buildroot}
+make pure_install DESTDIR=%{buildroot}
 find %{buildroot} -type f -name .packlist -exec rm -f {} ';'
-find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null ';'
-
 %{_fixperms} %{buildroot}/*
 
 # hrm.
@@ -72,16 +54,21 @@ find %{buildroot} -name '*.pl' -exec rm -v {} +
 %check
 make test
 
-%clean
-rm -rf %{buildroot} 
-
 %files
-%defattr(-,root,root,-)
 %doc README Changes Todo *.pl
 %{perl_vendorlib}/*
 %{_mandir}/man3/*.3*
 
 %changelog
+* Wed Aug 28 2013 Jitka Plesnikova <jplesnik at redhat.com> - 0.40-6
+- Clean up spec
+  - Drop removing buildroot and delete %%clean section
+  - Remove BuildRoot and %%defattr
+  - Replace PERL_INSTALL_ROOT by DESTDIR
+- Specify all dependencies
+- Fixed BZ #994030 - Remove the req/prov filtering from version docdir
+  (BZ#473874), because it is not needed
+
 * Sat Aug 03 2013 Petr Pisar <ppisar at redhat.com> - 0.40-5
 - Perl 5.18 rebuild
 


More information about the scm-commits mailing list