[chicken: 1/3] Nuke -Wall from optflags. Sigh.

Ricky Elrod codeblock at fedoraproject.org
Mon Sep 2 06:05:33 UTC 2013


commit 14b80988fd0e11c6b02dedc21096fd8e35e133d3
Author: Ricky Elrod <ricky at elrod.me>
Date:   Sat Aug 31 02:39:52 2013 -0400

    Nuke -Wall from optflags. Sigh.

 chicken.spec |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)
---
diff --git a/chicken.spec b/chicken.spec
index 00c3f48..ec7b45d 100644
--- a/chicken.spec
+++ b/chicken.spec
@@ -50,7 +50,13 @@ echo "#define C_BUILD_TAG \"compiled $(date '+%Y-%m-%d') on $(hostname)\"" > bui
 
 %endif
 
-make CFLAGS="%{optflags}" \
+# Chicken's build system is freaking horrible.
+# So, Fedora requires that we use optflags here - makes sense, they contain
+# some security related flags, etc. The issue is that Chicken uses the same
+# flags that it was compiled with when it compiles code for the end-user.
+# So if we pass -Wall here, it'll give the user a bunch of warnings when they
+# compile anything at all with `csc`. So that's lovely. -codeblock
+make CFLAGS="$(echo "%{optflags}" | sed 's/-Wall//')" \
      PREFIX=%{_prefix} \
      BINDIR=%{_bindir} \
      LIBDIR=%{_libdir} \
@@ -62,7 +68,7 @@ make CFLAGS="%{optflags}" \
      PLATFORM=linux
 
 %install
-make CFLAGS="%{optflags}" \
+make CFLAGS="$(echo "%{optflags}" | sed 's/-Wall//')" \
      PREFIX=%{_prefix} \
      BINDIR=%{_bindir} \
      LIBDIR=%{_libdir} \


More information about the scm-commits mailing list