[python-pyrad/el5] A better random number generator

Peter Lemenkov peter at fedoraproject.org
Thu Sep 5 12:11:18 UTC 2013


commit caa7e29286a7df667f3f2e655e0daf9e53cecae5
Author: Peter Lemenkov <lemenkov at gmail.com>
Date:   Thu Sep 5 16:11:05 2013 +0400

    A better random number generator
    
    Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>

 ...-pyrad-0001-Use-a-better-random-generator.patch |   47 ++++++++++++++++++++
 python-pyrad.spec                                  |   11 ++---
 2 files changed, 52 insertions(+), 6 deletions(-)
---
diff --git a/python-pyrad-0001-Use-a-better-random-generator.patch b/python-pyrad-0001-Use-a-better-random-generator.patch
new file mode 100644
index 0000000..ebde6ba
--- /dev/null
+++ b/python-pyrad-0001-Use-a-better-random-generator.patch
@@ -0,0 +1,47 @@
+From ee8b8a78eaaa14be0f15de0200915ad387555bc6 Mon Sep 17 00:00:00 2001
+From: Wichert Akkerman <wichert at wiggy.net>
+Date: Tue, 15 Jan 2013 16:55:54 +0100
+Subject: [PATCH 1/1] Use a better random generator.
+
+---
+ pyrad/packet.py | 9 ++++++---
+ 1 file changed, 6 insertions(+), 3 deletions(-)
+
+diff --git a/pyrad/packet.py b/pyrad/packet.py
+index e27e23e..8ec50b9 100644
+--- a/pyrad/packet.py
++++ b/pyrad/packet.py
+@@ -30,8 +30,11 @@ CoARequest		= 43
+ CoAACK			= 44
+ CoANAK			= 45
+ 
++# Use cryptographic-safe random generator as provided by the OS.
++random_generator = random.SystemRandom()
++
+ # Current ID
+-CurrentID		= random.randrange(1, 255)
++CurrentID		= random_generator.randrange(1, 255)
+ 
+ class PacketError(Exception):
+ 	pass
+@@ -212,7 +215,7 @@ class Packet(UserDict.UserDict):
+ 
+ 		data=""
+ 		for i in range(16):
+-			data+=chr(random.randrange(0,256))
++			data+=chr(random_generator.randrange(0,256))
+ 
+ 		return data
+ 	CreateAuthenticator=staticmethod(CreateAuthenticator)
+@@ -230,7 +233,7 @@ class Packet(UserDict.UserDict):
+ 		@rtype:  integer
+ 
+ 		"""
+-		return random.randrange(0,256)
++		return random_generator.randrange(0,256)
+ 
+ 
+ 	def ReplyPacket(self):
+-- 
+1.8.3.1
+
diff --git a/python-pyrad.spec b/python-pyrad.spec
index 94f6782..8236c70 100644
--- a/python-pyrad.spec
+++ b/python-pyrad.spec
@@ -6,18 +6,15 @@
 
 Name:		python-%{realname}
 Version:	1.1
-Release:	2%{?dist}
+Release:	3%{?dist}
 Summary:	Python RADIUS client
 Group:		Development/Languages
 License:	BSD
 URL:		http://www.wiggy.net/code/pyrad/
 Source0:	http://pypi.python.org/packages/source/p/%{realname}/%{realname}-%{version}.tar.gz
+Patch1:		python-pyrad-0001-Use-a-better-random-generator.patch
 BuildRoot:	%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
-%if 0%{?fedora} >= 8
-BuildRequires: python-setuptools-devel
-%else
 BuildRequires: python-setuptools
-%endif
 Requires:	python-twisted-core
 BuildArch:	noarch
 
@@ -47,13 +44,15 @@ rm -rf $RPM_BUILD_ROOT
 
 
 %files
-%defattr(-,root,root,-)
 %doc CHANGES.txt LICENSE.txt README.txt example
 %{python_sitelib}/%{realname}/
 %{python_sitelib}/%{realname}-%{version}-*.egg-info/
 
 
 %changelog
+* Thu Sep 05 2013 Peter Lemenkov <lemenkov at gmail.com> - 1.1-3
+- A better random number generator
+
 * Sat Apr 11 2009 Peter Lemenkov <lemenkov at gmail.com> 1.1-2
 - Fixed rpmling warning
 - Changed 'files' section


More information about the scm-commits mailing list