[kexec-tools] kdump-lib.sh: strip_comments is not implemented correcty

Baoquan He baoquan at fedoraproject.org
Sat Oct 12 08:07:00 UTC 2013


commit a68231599670e0758e3242719686a898025449f0
Author: Baoquan He <bhe at redhat.com>
Date:   Thu Oct 10 17:02:58 2013 +0800

    kdump-lib.sh: strip_comments is not implemented correcty
    
    In mkdumprd, strip_comments is not implemented correctly. Since arguments
    passed, strip_comments only take $1 and misses others. This caused
    problems. Such as below line, current code will only get "makedumpfile"
    and pass it to $config_val finally, then parameters for makedumpfile
    are missed.
    
    core_collector makedumpfile -c --message-level 1 -d 31
    
    Now modify function strip_comments.
    
    Signed-off-by: Baoquan He <bhe at redhat.com>
    Acked-by: WANG Chao <chaowang at redhat.com>
    Acked-by: Dave Young <dyoung at redhat.com>

 kdump-lib.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/kdump-lib.sh b/kdump-lib.sh
index 4df5315..e73ac09 100755
--- a/kdump-lib.sh
+++ b/kdump-lib.sh
@@ -20,5 +20,5 @@ is_raw_dump_target()
 
 strip_comments()
 {
-    echo $1 | sed -e 's/\(.*\)#.*/\1/'
+    echo $@ | sed -e 's/\(.*\)#.*/\1/'
 }


More information about the scm-commits mailing list