[gnome-settings-daemon/f20] Backport a patch from master to fix launching gnome-software from the notification

Richard Hughes rhughes at fedoraproject.org
Thu Oct 17 14:46:48 UTC 2013


commit 47b6b557e88639e549aa1103878fd6763a9de3d7
Author: Richard Hughes <richard at hughsie.com>
Date:   Thu Oct 17 15:45:52 2013 +0100

    Backport a patch from master to fix launching gnome-software from the notification

 ...rectly-start-gnome-software-when-clicking.patch |   26 ++++++++++++++++++++
 gnome-settings-daemon.spec                         |   12 ++++++++-
 2 files changed, 37 insertions(+), 1 deletions(-)
---
diff --git a/0001-updates-Correctly-start-gnome-software-when-clicking.patch b/0001-updates-Correctly-start-gnome-software-when-clicking.patch
new file mode 100644
index 0000000..9a2ce7f
--- /dev/null
+++ b/0001-updates-Correctly-start-gnome-software-when-clicking.patch
@@ -0,0 +1,26 @@
+From 8489dffe54e7c8374e6068f8e70cf4f8c09e0609 Mon Sep 17 00:00:00 2001
+From: Richard Hughes <richard at hughsie.com>
+Date: Thu, 17 Oct 2013 15:39:57 +0100
+Subject: [PATCH] updates: Correctly start gnome-software when clicking on the
+ notification buttons
+
+---
+ plugins/updates/gsd-updates-manager.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/plugins/updates/gsd-updates-manager.c b/plugins/updates/gsd-updates-manager.c
+index 901840e..9c4d3f1 100644
+--- a/plugins/updates/gsd-updates-manager.c
++++ b/plugins/updates/gsd-updates-manager.c
+@@ -224,7 +224,7 @@ start_gnome_software_with_mode (const gchar *mode)
+ 
+         argv = g_new0 (gchar *, 3);
+         argv[0] = g_build_filename (BINDIR, "gnome-software", NULL);
+-        argv[1] = g_strdup_printf ("--mode %s", mode);
++        argv[1] = g_strdup_printf ("--mode=%s", mode);
+         ret = g_spawn_async (NULL, argv, NULL, 0, NULL, NULL, NULL, &error);
+         if (!ret) {
+                 g_warning ("Failed to spawn gnome-software: %s", error->message);
+-- 
+1.8.3.1
+
diff --git a/gnome-settings-daemon.spec b/gnome-settings-daemon.spec
index 14765f0..57decde 100644
--- a/gnome-settings-daemon.spec
+++ b/gnome-settings-daemon.spec
@@ -6,7 +6,7 @@
 
 Name:           gnome-settings-daemon
 Version:        3.10.1
-Release:        1%{?dist}
+Release:        2%{?dist}
 Summary:        The daemon sharing settings from GNOME to GTK+/KDE applications
 
 Group:          System Environment/Daemons
@@ -17,6 +17,9 @@ Source:         http://download.gnome.org/sources/%{name}/3.10/%{name}-%{version
 # disable wacom for ppc/ppc64 (used on RHEL)
 Patch0:         %{name}-3.5.4-ppc-no-wacom.patch
 
+# already upstream, fixes launching gnome-software from the notification
+Patch1:         0001-updates-Correctly-start-gnome-software-when-clicking.patch
+
 BuildRequires:  gtk3-devel >= 3.7.8
 BuildRequires:  gnome-desktop3-devel >= %{gnome_desktop_version}
 BuildRequires:  xorg-x11-proto-devel libXxf86misc-devel
@@ -88,6 +91,8 @@ The %{name}-updates package contains the updates plugin for %{name}
 %patch0 -p1 -b .ppc-no-wacom
 %endif
 
+%patch1 -p1 -b .updates-fix-notification
+
 autoreconf -i -f
 
 %build
@@ -272,6 +277,11 @@ glib-compile-schemas %{_datadir}/glib-2.0/schemas &> /dev/null || :
 %{_datadir}/glib-2.0/schemas/org.gnome.settings-daemon.plugins.updates.gschema.xml
 
 %changelog
+* Thu Oct 17 2013 Richard Hughes <rhughes at redhat.com> - 3.10.1-2
+- Backport a patch from master to fix launching gnome-software from the
+  notification.
+- Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=710038
+
 * Tue Oct 15 2013 Richard Hughes <rhughes at redhat.com> - 3.10.1-1
 - Update to 3.10.1
 


More information about the scm-commits mailing list