[btkbdd] Attempt at saner SPEC file formatting

Lubomir Rintel lkundrak at fedoraproject.org
Thu Oct 24 09:44:15 UTC 2013


commit cb4913cf877383ca0c2c6ae9598719584afef47a
Author: Lubomir Rintel <lkundrak at v3.sk>
Date:   Thu Oct 24 11:39:53 2013 +0200

    Attempt at saner SPEC file formatting
    
    I'm doing this semi-automatically across all packages I maintain, since some
    are several years old and since then several have suffered bit-rot and such.
    I'm fixing up the following:
    
    - Old RPM relics (such as %defattr, BuildRoot or %clean sections)
    - Whitespace errors (such as trailing spaces)
    - Consistent use of %{buildroot}
    - Dropping useless %{name} expansions that harm legibility
    - Consistent spacing between RPM sections
    - Bad days in %changelogs

 btkbdd.spec |   29 +++++++++++++----------------
 1 files changed, 13 insertions(+), 16 deletions(-)
---
diff --git a/btkbdd.spec b/btkbdd.spec
index 0f8b3e1..0ad0d47 100644
--- a/btkbdd.spec
+++ b/btkbdd.spec
@@ -1,26 +1,26 @@
 Name:           btkbdd
 Version:        1.3
-Release:        3%{?dist}
+Release:        4%{?dist}
 Summary:        Bluetooth keyboard service
 
 Group:          System Environment/Daemons
 License:        GPL+
 URL:            https://github.com/lkundrak/virtkbd/blob/master/btkbdd.pod
 Source0:        https://github.com/downloads/lkundrak/virtkbd/%{name}-%{version}.tar.gz
-BuildRoot:      %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
 
 BuildRequires:  bluez-libs-devel /usr/bin/pod2man
 BuildRequires:  systemd-units
 Requires:       udev systemd
 
 %description
-This tool starts a Bluetooth HID Keyboard service, serving keystrokes 
-obtained via Linux Input subsystem's event device (evdev). In practical 
-terms, it turns your Linux box with a physical keyboard into a Bluetooth 
-keyboard, which can be used by various Bluetooth HID capable devices, 
-including desktop or tablet computers, smart phones, game consoles and so 
+This tool starts a Bluetooth HID Keyboard service, serving keystrokes
+obtained via Linux Input subsystem's event device (evdev). In practical
+terms, it turns your Linux box with a physical keyboard into a Bluetooth
+keyboard, which can be used by various Bluetooth HID capable devices,
+including desktop or tablet computers, smart phones, game consoles and so
 on.
 
+
 %prep
 %setup -q
 
@@ -30,12 +30,7 @@ make %{?_smp_mflags} CFLAGS="%{optflags}"
 
 
 %install
-rm -rf $RPM_BUILD_ROOT
-make install DESTDIR=$RPM_BUILD_ROOT PREFIX=%{_prefix}
-
-
-%clean
-rm -rf $RPM_BUILD_ROOT
+make install DESTDIR=%{buildroot} PREFIX=%{_prefix}
 
 
 %postun
@@ -43,7 +38,6 @@ rm -rf $RPM_BUILD_ROOT
 
 
 %files
-%defattr(-,root,root,-)
 %{_sbindir}/btkbdd
 %config(noreplace) %{_sysconfdir}/udev/rules.d/90-btkbdd.rules
 %dir %{_localstatedir}/lib/btkbdd
@@ -53,6 +47,9 @@ rm -rf $RPM_BUILD_ROOT
 
 
 %changelog
+* Thu Oct 24 2013 Lubomir Rintel <lkundrak at v3.sk> - 1.3-4
+- Bulk sad and useless attempt at consistent SPEC file formatting
+
 * Sat Aug 03 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.3-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
 
@@ -65,9 +62,9 @@ rm -rf $RPM_BUILD_ROOT
 * Wed Jul 18 2012 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.2-2
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
 
-* Mon Jan 09 2011 Lubomir Rintel <lkundrak at v3.sk> - 1.2-1
+* Sun Jan 09 2011 Lubomir Rintel <lkundrak at v3.sk> - 1.2-1
 - Do not own rules.d (Volker Fröhlich, #772504)
 - Change state directory location to match package name
 
-* Wed Jan 04 2011 Lubomir Rintel <lkundrak at v3.sk> - 1.1-1
+* Tue Jan 04 2011 Lubomir Rintel <lkundrak at v3.sk> - 1.1-1
 - Initial packaging


More information about the scm-commits mailing list