[stalonetray] Add patch to fix compilation with -Werror=format-security

Ben Boeckel mathstuf at fedoraproject.org
Thu Nov 21 02:13:47 UTC 2013


commit 893b32d6347222fbc2a12e7e234600b44f486300
Author: Ben Boeckel <mathstuf at gmail.com>
Date:   Wed Nov 20 21:21:32 2013 -0500

    Add patch to fix compilation with -Werror=format-security

 stalonetray-0.8.1--Werror-format-security.patch |   17 +++++++++++++++++
 stalonetray.spec                                |    8 ++++++--
 2 files changed, 23 insertions(+), 2 deletions(-)
---
diff --git a/stalonetray-0.8.1--Werror-format-security.patch b/stalonetray-0.8.1--Werror-format-security.patch
new file mode 100644
index 0000000..e9eb0e7
--- /dev/null
+++ b/stalonetray-0.8.1--Werror-format-security.patch
@@ -0,0 +1,17 @@
+diff -u -r -U5 stalonetray-0.8.1/src/debug.h stalonetray-0.8.1.error-format/src/debug.h
+--- stalonetray-0.8.1/src/debug.h	2009-11-15 22:32:35.000000000 -0500
++++ stalonetray-0.8.1.-Werror-format-security/src/debug.h	2013-11-20 21:18:58.925942933 -0500
+@@ -28,11 +28,12 @@
+ 
+ /* Disables all output from debugging macros */
+ void debug_disable_output();
+ 
+ /* Print the message to STDERR (in the sake of portability, we do not use varadic macros) */
+-void print_message_to_stderr(const char *fmt,...);
++void print_message_to_stderr(const char *fmt,...)
++    __attribute__((__format__(__printf, 1, 2)));
+ 
+ #ifdef DEBUG
+ /* The following defines control what is printed in each logged line */	
+ /* Print window name */
+ #define TRACE_WM_NAME
diff --git a/stalonetray.spec b/stalonetray.spec
index eab998f..d4f5fee 100644
--- a/stalonetray.spec
+++ b/stalonetray.spec
@@ -1,6 +1,6 @@
 Name:           stalonetray
 Version:        0.8.1
-Release:        3%{?dist}
+Release:        4%{?dist}
 Summary:        A stand alone notification area
 
 Group:          User Interface/Desktops
@@ -8,6 +8,7 @@ Group:          User Interface/Desktops
 License:        GPLv2+
 URL:            http://stalonetray.sourceforge.net/
 Source0:        http://downloads.sourceforge.net/sourceforge/%{name}/%{name}-%{version}.tar.bz2
+Patch0:         stalonetray-0.8.1--Werror-format-security.patch
 
 BuildRequires:  libX11-devel
 
@@ -18,7 +19,7 @@ support is planned. Stalonetray runs under virtually any window manager.
 
 %prep
 %setup -q
-
+%patch0 -p1 -b .error-format
 
 %build
 %configure
@@ -38,6 +39,9 @@ make install DESTDIR=%{buildroot} INSTALL="install -p"
 
 
 %changelog
+* Wed Nov 20 2013 Ben Boeckel <mathstuf at gmail.com> - 0.8.1-4
+- Add patch to fix compilation with -Werror=format-security
+
 * Sun Aug 04 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.8.1-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
 


More information about the scm-commits mailing list