[gnome-initial-setup/f20] Resolves: rhbz#1027507 - [abrt] gnome-initial-setup-3.10.1.1-2.fc20: magazine_chain_pop_head

rtcm rtcm at fedoraproject.org
Thu Nov 28 18:58:14 UTC 2013


commit 82dff6b79d92c10fceb5e502927edc5a1526b3d2
Author: Rui Matos <tiagomatos at gmail.com>
Date:   Thu Nov 28 16:23:40 2013 +0100

    Resolves: rhbz#1027507 - [abrt] gnome-initial-setup-3.10.1.1-2.fc20: magazine_chain_pop_head

 0001-goa-Prevent-a-use-after-free.patch |   27 +++++++++++++++++++++++++++
 gnome-initial-setup.spec                |    7 ++++++-
 2 files changed, 33 insertions(+), 1 deletions(-)
---
diff --git a/0001-goa-Prevent-a-use-after-free.patch b/0001-goa-Prevent-a-use-after-free.patch
new file mode 100644
index 0000000..0a015a4
--- /dev/null
+++ b/0001-goa-Prevent-a-use-after-free.patch
@@ -0,0 +1,27 @@
+From 48302b7796e7016dc563f3d6366982f073b27ebe Mon Sep 17 00:00:00 2001
+From: "Jasper St. Pierre" <jstpierre at mecheye.net>
+Date: Sat, 9 Nov 2013 11:43:48 -0500
+Subject: [PATCH] goa: Prevent a use-after-free
+
+If the user dismisses the dialog, we'll get an error and free it,
+but forget to set it to NULL, and segfault.
+---
+ gnome-initial-setup/pages/goa/gis-goa-page.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/gnome-initial-setup/pages/goa/gis-goa-page.c b/gnome-initial-setup/pages/goa/gis-goa-page.c
+index 85b8ff5..3228159 100644
+--- a/gnome-initial-setup/pages/goa/gis-goa-page.c
++++ b/gnome-initial-setup/pages/goa/gis-goa-page.c
+@@ -106,7 +106,7 @@ on_have_providers (GObject       *source,
+           gtk_dialog_run (GTK_DIALOG (dialog));
+           gtk_widget_destroy (dialog);
+         }
+-      g_error_free (error);
++      g_clear_error (&error);
+     }
+ 
+   g_list_free_full (providers, g_object_unref);
+-- 
+1.8.3.1
+
diff --git a/gnome-initial-setup.spec b/gnome-initial-setup.spec
index 7f17b3c..bfc178c 100644
--- a/gnome-initial-setup.spec
+++ b/gnome-initial-setup.spec
@@ -1,6 +1,6 @@
 Name:           gnome-initial-setup
 Version:        3.10.1.1
-Release:        2%{?dist}
+Release:        3%{?dist}
 Summary:        Bootstrapping your OS
 
 License:        GPLv2+
@@ -13,6 +13,7 @@ Patch0: yelp-fixes.patch
 
 # upstream fix
 Patch1: goa-add.patch
+Patch2: 0001-goa-Prevent-a-use-after-free.patch
 
 %global nm_version 0.9.6.4
 %global glib_required_version 2.36.0
@@ -70,6 +71,7 @@ you through configuring it. It is integrated with gdm.
 %setup -q
 %patch0 -p1 -b .yelp-fixes
 %patch1 -p1 -b .goa
+%patch2 -p1
 
 autoreconf -i -f
 
@@ -111,6 +113,9 @@ useradd -rM -d /run/gnome-initial-setup/ -s /sbin/nologin %{name} &>/dev/null ||
 %{_datadir}/polkit-1/rules.d/20-gnome-initial-setup.rules
 
 %changelog
+* Thu Nov 28 2013 Rui Matos <rmatos at redhat.com> - 3.10.1.1-3
+- Resolves: rhbz#1027507 - [abrt] gnome-initial-setup-3.10.1.1-2.fc20: magazine_chain_pop_head
+
 * Fri Nov  1 2013 Matthias Clasen <mclasen at redhat.com> - 3.10.1.1-2
 - Fix goa add dialog to not be empty
 


More information about the scm-commits mailing list