[spindown] Build correctly with -Werror=format-security (resolves bz1037334)

Martin Cermak mcermak at fedoraproject.org
Tue Dec 3 09:48:19 UTC 2013


commit bd93d7cabcfa92aa20f040b396f1c4a2f3095266
Author: Martin Cermak <mcermak at redhat.com>
Date:   Tue Dec 3 08:53:50 2013 +0000

    Build correctly with -Werror=format-security (resolves bz1037334)

 spindown-0.4.0-bz1037334.patch |   13 +++++++++++++
 spindown.spec                  |    9 +++++++--
 2 files changed, 20 insertions(+), 2 deletions(-)
---
diff --git a/spindown-0.4.0-bz1037334.patch b/spindown-0.4.0-bz1037334.patch
new file mode 100644
index 0000000..6b07a67
--- /dev/null
+++ b/spindown-0.4.0-bz1037334.patch
@@ -0,0 +1,13 @@
+diff --git a/src/log.cpp b/src/log.cpp
+index 99640a1..2beac44 100644
+--- a/src/log.cpp
++++ b/src/log.cpp
+@@ -54,7 +54,7 @@ void Log::open( char* ident, int option, int facility)
+ void Log::message(int facility_priority, string message)
+ {
+     if( opend )
+-        syslog( facility_priority, message.data() );
++        syslog( facility_priority, "%s", message.data() );
+ }
+ 
+ void Log::close()
diff --git a/spindown.spec b/spindown.spec
index ed8a384..e818d0a 100644
--- a/spindown.spec
+++ b/spindown.spec
@@ -1,7 +1,7 @@
 Summary:    Daemon that can spin idle disks down
 Name:       spindown
 Version:    0.4.0
-Release:    12%{?dist}
+Release:    13%{?dist}
 License:    GPLv3+
 Group:      System Environment/Daemons
 Url:        http://code.google.com/p/spindown
@@ -12,6 +12,7 @@ Source2:    01spindown
 Patch0: spindown-0.4.0-Makefile.patch
 Patch1: spindown-0.4.0-iniparser.patch
 Patch2: spindown-0.4.0-iniparser-3.0-1.patch
+Patch3: spindown-0.4.0-bz1037334.patch
 
 Requires(preun): systemd-units
 
@@ -35,6 +36,7 @@ cp -pf %{SOURCE2} 01spindown
 %patch0 -p1
 %patch1 -p1
 %patch2 -p1
+%patch3 -p1
 
 %build
 make %{?_smp_mflags} OPT="$RPM_OPT_FLAGS"
@@ -61,6 +63,9 @@ fi
 %config(noreplace) %{_sysconfdir}/spindown.conf
 
 %changelog
+* Tue Dec 03 2013 Martin Cermak <mcermak at redhat.com> 0.4.0-13
+- Build correctly with -Werror=format-security (resolves bz1037334)
+
 * Sun Aug 04 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.4.0-12
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
 
@@ -77,7 +82,7 @@ fi
 - Improved fix for bz787231 as discussed in bz769059#c7
 - Fixed systemd unit installation
 
-* Fri Feb  3 2012 Martin Cermak <mcermak at redhat.com> 0.4.0-7
+* Fri Feb 03 2012 Martin Cermak <mcermak at redhat.com> 0.4.0-7
 - Behave correctly after waking from suspend (resolves bz787231)
 
 * Tue Jan 31 2012 Martin Cermak <mcermak at redhat.com> 0.4.0-6


More information about the scm-commits mailing list