[vconfig] Modernize the spec file

Petr Pisar ppisar at fedoraproject.org
Tue Dec 3 12:25:29 UTC 2013


commit c52c4e4df964b991f0367c689fc493593d34db79
Author: Petr Písař <ppisar at redhat.com>
Date:   Tue Dec 3 13:21:00 2013 +0100

    Modernize the spec file

 .rpmlint     |    2 ++
 vconfig.spec |   37 ++++++++++++++++---------------------
 2 files changed, 18 insertions(+), 21 deletions(-)
---
diff --git a/.rpmlint b/.rpmlint
new file mode 100644
index 0000000..b350c84
--- /dev/null
+++ b/.rpmlint
@@ -0,0 +1,2 @@
+from Config import *
+addFilter("spelling-error .* ip");
diff --git a/vconfig.spec b/vconfig.spec
index cd5a011..271cef4 100644
--- a/vconfig.spec
+++ b/vconfig.spec
@@ -1,18 +1,17 @@
-Summary: Linux 802.1q VLAN configuration utility
-Name: vconfig
-Version: 1.9
-Release: 14%{?dist}
-License: GPLv2+
-Group: System Environment/Base
-Source: http://www.candelatech.com/~greear/vlan/vlan.%{version}.tar.gz
+Name:       vconfig
+Version:    1.9
+Release:    14%{?dist}
+Summary:    Linux 802.1q VLAN configuration utility
+License:    GPLv2+
+Group:      System Environment/Base
+URL:        http://www.candelatech.com/~greear/vlan.html
+Source:     http://www.candelatech.com/~greear/vlan/vlan.%{version}.tar.gz
 # Fix a security warning by compiler, bug #1037376
-Patch0: %{name}-1.9-Pass-compilation-with-Werror-format-security.patch
-URL: http://www.candelatech.com/~greear/vlan.html
-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-%define _sbin /sbin
+Patch0:     %{name}-1.9-Pass-compilation-with-Werror-format-security.patch
 
 %description 
 The vconfig program configures and adjusts 802.1q VLAN parameters.
+This tool is deprecated in favor of "ip link" command.
 
 %prep
 %setup -q -n vlan
@@ -24,23 +23,19 @@ rm -f vconfig
 make CCFLAGS="%{optflags}" STRIP=/bin/true vconfig
 
 %install
-rm -rf ${RPM_BUILD_ROOT}
-%{__install} -D -m755 vconfig ${RPM_BUILD_ROOT}%{_sbin}/vconfig
-%{__install} -D -m644 vconfig.8 ${RPM_BUILD_ROOT}%{_mandir}/man8/vconfig.8
-rm -rf contrib/CVS
-
-%clean 
-rm -rf ${RPM_BUILD_ROOT}
+install -D -m755 vconfig ${RPM_BUILD_ROOT}%{_sbindir}/vconfig
+install -D -m644 vconfig.8 ${RPM_BUILD_ROOT}%{_mandir}/man8/vconfig.8
 
 %files 
-%defattr(-, root, root, 0755)
-%doc CHANGELOG contrib README vlan.html vlan_test.pl
-%{_sbin}/vconfig
+%doc CHANGELOG README vlan.html vlan_test.pl
+%{_sbindir}/vconfig
 %{_mandir}/man8/vconfig.8*
 
 %changelog
 * Tue Dec 03 2013 Petr Pisar <ppisar at redhat.com> - 1.9-14
 - Fix a security warning by compiler (bug #1037376)
+- Move the executable to /usr/sbin
+- Modernize the spec file
 
 * Sun Aug 04 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 1.9-13
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild


More information about the scm-commits mailing list