[tigervnc] Fixed build failure with -Werror=format-security (bug #1037358).

Tim Waugh twaugh at fedoraproject.org
Tue Dec 3 16:51:09 UTC 2013


commit 475c2dd0e7450f77f58b4fb3abfeceb08e183e49
Author: Tim Waugh <twaugh at redhat.com>
Date:   Tue Dec 3 16:48:23 2013 +0000

    Fixed build failure with -Werror=format-security (bug #1037358).
    
    Resolves: rhbz#1037358

 tigervnc-format-security.patch |   12 ++++++++++++
 tigervnc.spec                  |    9 ++++++++-
 2 files changed, 20 insertions(+), 1 deletions(-)
---
diff --git a/tigervnc-format-security.patch b/tigervnc-format-security.patch
new file mode 100644
index 0000000..36f3fc8
--- /dev/null
+++ b/tigervnc-format-security.patch
@@ -0,0 +1,12 @@
+diff -up tigervnc-1.3.0/vncviewer/vncviewer.cxx.format-security tigervnc-1.3.0/vncviewer/vncviewer.cxx
+--- tigervnc-1.3.0/vncviewer/vncviewer.cxx.format-security	2013-12-03 16:47:04.802800182 +0000
++++ tigervnc-1.3.0/vncviewer/vncviewer.cxx	2013-12-03 16:47:08.680820024 +0000
+@@ -309,7 +309,7 @@ interpretViaParam(char *remoteHost, int
+ 
+   snprintf(vncServerName, VNCSERVERNAMELEN, "localhost::%d", localPort);
+   vncServerName[VNCSERVERNAMELEN - 1] = '\0';
+-  vlog.error(vncServerName);
++  vlog.error("%s", vncServerName);
+ 
+   return 0;
+ }
diff --git a/tigervnc.spec b/tigervnc.spec
index 91dc677..4e2d3e4 100644
--- a/tigervnc.spec
+++ b/tigervnc.spec
@@ -1,6 +1,6 @@
 Name:		tigervnc
 Version:	1.3.0
-Release:	8%{?dist}
+Release:	9%{?dist}
 Summary:	A TigerVNC remote display system
 
 Group:		User Interface/Desktops
@@ -47,6 +47,7 @@ Patch7:		tigervnc-manpages.patch
 Patch8:		tigervnc-getmaster.patch
 Patch9:		tigervnc-shebang.patch
 Patch10:	tigervnc-1.3.0-xserver-1.15.patch
+Patch11:	tigervnc-format-security.patch
 
 %description
 Virtual Network Computing (VNC) is a remote display system which
@@ -171,6 +172,9 @@ popd
 
 %patch10 -p1 -b .115
 
+# Fixed build failure with -Werror=format-security (bug #1037358).
+%patch11 -p1 -b .format-security
+
 %build
 %ifarch sparcv9 sparc64 s390 s390x
 export CFLAGS="$RPM_OPT_FLAGS -fPIC"
@@ -343,6 +347,9 @@ fi
 %{_datadir}/icons/hicolor/*/apps/*
 
 %changelog
+* Tue Dec  3 2013 Tim Waugh <twaugh at redhat.com> 1.3.0-9
+- Fixed build failure with -Werror=format-security (bug #1037358).
+
 * Thu Nov 07 2013 Adam Jackson <ajax at redhat.com> 1.3.0-8
 - Rebuild against xserver 1.15RC1
 


More information about the scm-commits mailing list