[qemu] Clarify chrpath comment
Cole Robinson
crobinso at fedoraproject.org
Wed Dec 4 23:15:07 UTC 2013
commit cf5f9d239ebefdb9824d6a7bbb21c46ecb639f60
Author: Cole Robinson <crobinso at redhat.com>
Date: Wed Dec 4 18:13:23 2013 -0500
Clarify chrpath comment
qemu.spec | 10 +++++++---
1 files changed, 7 insertions(+), 3 deletions(-)
---
diff --git a/qemu.spec b/qemu.spec
index dbe9ba9..5b20dad 100644
--- a/qemu.spec
+++ b/qemu.spec
@@ -1022,10 +1022,14 @@ rm -f $RPM_BUILD_ROOT%{_libdir}/pkgconfig/libcacard.pc
rm -rf $RPM_BUILD_ROOT%{_includedir}/cacard
%endif
-# When building using 'rpmbuild' or 'fedpkg local', RPATHs are left in
+# When building using 'rpmbuild' or 'fedpkg local', RPATHs can be left in
# the binaries and libraries (although this doesn't occur when
-# building in Koji, for some unknown reason). In any case it should
-# always be safe to remove RPATHs from the final binaries:
+# building in Koji, for some unknown reason). Some discussion here:
+#
+# https://lists.fedoraproject.org/pipermail/devel/2013-November/192553.html
+#
+# In any case it should always be safe to remove RPATHs from
+# the final binaries:
for f in $RPM_BUILD_ROOT%{_bindir}/* $RPM_BUILD_ROOT%{_libdir}/* \
$RPM_BUILD_ROOT%{_libexecdir}/*; do
if file $f | grep -q ELF; then chrpath --delete $f; fi
More information about the scm-commits
mailing list