[uudeview] fixes "uudeview FTBFS if "-Werror=format-security" flag is used" (#1037373)

Adrian Reber adrian at fedoraproject.org
Thu Dec 5 15:14:22 UTC 2013


commit a0f458850f935ebdc277d2f3a9ba83319641928e
Author: Adrian Reber <adrian at lisas.de>
Date:   Thu Dec 5 16:14:17 2013 +0100

    fixes "uudeview FTBFS if "-Werror=format-security" flag is used" (#1037373)

 uudeview-format-security.patch |   22 ++++++++++++++++++++++
 uudeview.spec                  |   19 ++++++++++++-------
 2 files changed, 34 insertions(+), 7 deletions(-)
---
diff --git a/uudeview-format-security.patch b/uudeview-format-security.patch
new file mode 100644
index 0000000..42d9f9f
--- /dev/null
+++ b/uudeview-format-security.patch
@@ -0,0 +1,22 @@
+diff --git a/unix/uuenview.c b/unix/uuenview.c
+index 7acfd3b..726a2a6 100644
+--- a/unix/uuenview.c
++++ b/unix/uuenview.c
+@@ -310,7 +310,7 @@ SendMkCommand (char **rcptlist, char *towhom, char *subject, int isemail)
+   }
+ 
+   if ((*rcptlist = (char *) malloc (strlen (towhom) + 16)) == NULL) {
+-    fprintf (stderr, "error: Out of memory allocating %d bytes\n",
++    fprintf (stderr, "error: Out of memory allocating %zd bytes\n",
+ 	     strlen (towhom)+16);
+     _FP_free (command);
+     return NULL;
+@@ -483,7 +483,7 @@ AttachFiles (char *towhom, char *subject,
+       if (_FP_stristr (input, "multipart") != NULL) {
+ 	/* it is already a multipart posting. grab the boundary */
+ 	if ((ptr = _FP_stristr (input, "boundary=")) != NULL) {
+-	  fprintf(thepipe,  input);
++	  fprintf(thepipe,  "%s", input);
+ 	  strcpy (boundary, ParseValue (ptr));
+ 	  hadmulti = 1;
+ 	}
diff --git a/uudeview.spec b/uudeview.spec
index 9ac8ced..8b77d6a 100644
--- a/uudeview.spec
+++ b/uudeview.spec
@@ -1,12 +1,13 @@
 Name:           uudeview
 Version:        0.5.20
-Release:        27%{?dist}
+Release:        28%{?dist}
 
 License:        GPLv2+
 Group:          Applications/File
 Source:         http://www.fpx.de/fp/Software/UUDeview/download/uudeview-0.5.20.tar.gz
 Source1:        xdeview.desktop
-Patch:          uudeview-debian-patches.patch
+Patch0:         uudeview-debian-patches.patch
+Patch1:         uudeview-format-security.patch
 URL:            http://www.fpx.de/fp/Software/UUDeview/
 Summary:        Applications for uuencoding, uudecoding, ...
 BuildRequires:  inews, tcl, tk
@@ -38,7 +39,8 @@ This package contains header files and static libraries for uulib.
 
 %prep
 %setup -q
-%patch -p1
+%patch0 -p1
+%patch1 -p1
 %{__sed} -i -e "s,psfig,epsfig,g" doc/library.ltx
 %{__sed} -i -e "s,for ff_subdir in lib,for ff_subdir in %{_lib},g" configure
 
@@ -78,6 +80,9 @@ install -p -m 0644 uulib/libuu.a $RPM_BUILD_ROOT/%{_libdir}/
 %{_libdir}/*.a
 
 %changelog
+* Thu Dec 05 2013 Adrian Reber <adrian at lisas.de> - 0.5.20-28
+- fixes "uudeview FTBFS if "-Werror=format-security" flag is used" (#1037373)
+
 * Sun Aug 04 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.5.20-27
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
 
@@ -218,13 +223,13 @@ install -p -m 0644 uulib/libuu.a $RPM_BUILD_ROOT/%{_libdir}/
 
 * Thu Oct 05 2000 Lenny Cartier <lenny at mandrakesoft.com> 0.5.13-3mdk
 - used - even if i'm sux ;) - the srpm from Alexander Skwar <ASkwar at linux-mandrake.com> :
-	Wed Oct  4 2000 Alexander Skwar <ASkwar at Linux-Mandrake.com> 0.5.13-3mdk
-	- Ever wondered why the binary package is so small?  Well, some of us may
-	like to have the executable, dunno about you.... (lenny sux)
+
+Wed Oct  4 2000 Alexander Skwar <ASkwar at Linux-Mandrake.com> 0.5.13-3mdk
+- Ever wondered why the binary package is so small?  Well, some of us may
+  like to have the executable, dunno about you.... (lenny sux)
 
 * Tue Sep 19 2000 Lenny Cartier <lenny at mandrakesoft.com> 0.5.13-2mdk
 - bm & macros
 
 * Tue Jun 13 2000 John Johnson <jjohnson at linux-mandrake.com> 0.5.13-1mdk
 - Made Mandrake rpm
-


More information about the scm-commits mailing list