[libreoffice] -Werror is for upstream, not for packages

David Tardon dtardon at fedoraproject.org
Sat Jan 18 13:38:36 UTC 2014


commit b9adaae17b4f33341825cf7da42bde10f15c5f58
Author: David Tardon <dtardon at redhat.com>
Date:   Sat Jan 18 12:23:37 2014 +0100

    -Werror is for upstream, not for packages
    
    ... especially as it breaks our build in configure:
    
    configure:8237: gcc  -O2 -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic -Wl,-z,relro  conftest.c  >&5
    cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security ]

 libreoffice.spec |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libreoffice.spec b/libreoffice.spec
index c7a5cd0..5aa9097 100644
--- a/libreoffice.spec
+++ b/libreoffice.spec
@@ -1045,7 +1045,7 @@ export PATH=$QT4DIR/bin:$PATH
 #use the RPM_OPT_FLAGS but remove the OOo overridden ones
 for i in $RPM_OPT_FLAGS; do
         case "$i" in
-                -pipe|-Wall|-g|-fexceptions) continue;;
+                -pipe|-Wall|-Werror*|-g|-fexceptions) continue;;
         esac
         ARCH_FLAGS="$ARCH_FLAGS $i"
 done


More information about the scm-commits mailing list