[libguestfs] Refactor 'runtests' macro.

Richard W.M. Jones rjones at fedoraproject.org
Tue Feb 18 15:26:58 UTC 2014


commit 380228e16d1be3de89d400ea90e8d5bccfa42cea
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Tue Feb 18 15:26:45 2014 +0000

    Refactor 'runtests' macro.
    
    No change, this is just code motion and commenting.

 libguestfs.spec |   14 +++++++++-----
 1 files changed, 9 insertions(+), 5 deletions(-)
---
diff --git a/libguestfs.spec b/libguestfs.spec
index 512d36f..4728fa0 100644
--- a/libguestfs.spec
+++ b/libguestfs.spec
@@ -1,9 +1,15 @@
-# Enable to run tests during check
-# Default is enabled
+# Run tests during check.  Default is enabled on most architectures.
+# You can override this by putting '%libguestfs_runtests 0' into
+# '~/.rpmmacros'
 %if %{defined libguestfs_runtests}
 %global runtests %{libguestfs_runtests}
 %else
+%ifnarch ppc ppc64
 %global runtests 1
+%else
+# Disabled on ppc, ppc64 (secondary arches), see RHBZ#1036742.
+%global runtests 0
+%endif
 %endif
 
 %global _hardened_build 1
@@ -688,12 +694,10 @@ popd
 export SKIP_TEST_VIRT_ALIGNMENT_SCAN_GUESTS_SH=1
 export SKIP_TEST_VIRT_DF_GUESTS_SH=1
 
-# Disabled on ppc, ppc64 (secondary arches), see RHBZ#1036742.
-%ifnarch ppc ppc64
 %if %{runtests}
 make quickcheck
 make check -k
-%endif
+
 %endif
 
 


More information about the scm-commits mailing list