[libguestfs] Enable libvirt debugging when running make quickcheck (thanks: Jiri Denemark)

Richard W.M. Jones rjones at fedoraproject.org
Tue Mar 4 15:18:35 UTC 2014


commit 6357e3d5f750ea60a98b4bba7d662b4561e881db
Author: Richard W.M. Jones <rjones at redhat.com>
Date:   Tue Mar 4 15:16:32 2014 +0000

    Enable libvirt debugging when running make quickcheck (thanks: Jiri Denemark)

 libguestfs.spec |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)
---
diff --git a/libguestfs.spec b/libguestfs.spec
index 295941f..3e78baf 100644
--- a/libguestfs.spec
+++ b/libguestfs.spec
@@ -782,9 +782,11 @@ export SKIP_TEST_VIRT_DF_GUESTS_SH=1
 
 %if %{runtests}
 
-# Do make quickcheck first, to fail early if the appliance is
-# obviously broken.  Also dump libvirt log files if this happens.
-if ! make quickcheck; then
+# Do make quickcheck first, to fail early if the appliance or libvirt
+# is obviously broken.  Also dump libvirt log files if this happens.
+# Since it's most likely libvirt which is broken, make sure libvirt
+# debugging is enabled here.
+if ! make quickcheck LIBVIRT_DEBUG=1; then
     cat $HOME/.cache/libvirt/qemu/log/*
     exit 1
 fi


More information about the scm-commits mailing list