[perl-Test-Harness/f20] Do not warn on tainted test without PERL5LIB environment variable

Petr Pisar ppisar at fedoraproject.org
Mon Apr 28 10:29:15 UTC 2014


commit d159af9735bc6860c9b6be3ad1b3645390834f44
Author: Petr Písař <ppisar at redhat.com>
Date:   Mon Apr 28 12:26:06 2014 +0200

    Do not warn on tainted test without PERL5LIB environment variable

 ...-on-tainted-test-without-PERL5LIB-envirom.patch |   40 ++++++++++++++++++++
 perl-Test-Harness.spec                             |   10 ++++-
 2 files changed, 49 insertions(+), 1 deletions(-)
---
diff --git a/Test-Harness-3.28-Do-not-warn-on-tainted-test-without-PERL5LIB-envirom.patch b/Test-Harness-3.28-Do-not-warn-on-tainted-test-without-PERL5LIB-envirom.patch
new file mode 100644
index 0000000..18e2090
--- /dev/null
+++ b/Test-Harness-3.28-Do-not-warn-on-tainted-test-without-PERL5LIB-envirom.patch
@@ -0,0 +1,40 @@
+From ce0f976bb88b5828373b1579cc2a0d95a8e9f664 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar at redhat.com>
+Date: Mon, 28 Apr 2014 11:05:41 +0200
+Subject: [PATCH] Do not warn on tainted test without PERL5LIB enviroment
+ variable
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+This fix is ported from upstream commit:
+
+commit 0a9d31df86597d1480df81c97b688f90d4fe63ba
+Author: Leon Timmermans <fawaka at gmail.com>
+Date:   Sun Jul 28 21:05:57 2013 +0200
+
+    Added use warnings to all modules
+
+<https://rt.cpan.org/Public/Bug/Display.html?id=85106>
+
+Signed-off-by: Petr Písař <ppisar at redhat.com>
+---
+ lib/TAP/Parser/SourceHandler/Perl.pm | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/lib/TAP/Parser/SourceHandler/Perl.pm b/lib/TAP/Parser/SourceHandler/Perl.pm
+index 9257f6a..46ee1fc 100644
+--- a/lib/TAP/Parser/SourceHandler/Perl.pm
++++ b/lib/TAP/Parser/SourceHandler/Perl.pm
+@@ -167,7 +167,7 @@ sub _mangle_switches {
+     # PERL5LIB as -I switches and place PERL5OPT on the command line
+     # in order that it be seen.
+     if ( $class->_has_taint_switch($switches) ) {
+-        my @perl5lib = split /$Config{path_sep}/, $ENV{PERL5LIB};
++        my @perl5lib = defined $ENV{PERL5LIB} ? split /$Config{path_sep}/, $ENV{PERL5LIB} : ();
+         return (
+             $libs,
+             [   @{$switches},
+-- 
+1.9.0
+
diff --git a/perl-Test-Harness.spec b/perl-Test-Harness.spec
index ec38eea..171b2b4 100644
--- a/perl-Test-Harness.spec
+++ b/perl-Test-Harness.spec
@@ -1,11 +1,14 @@
 Name:           perl-Test-Harness
 Version:        3.28
-Release:        3%{?dist}
+Release:        4%{?dist}
 Summary:        Run Perl standard test scripts with statistics
 License:        GPL+ or Artistic
 Group:          Development/Libraries
 URL:            http://search.cpan.org/dist/Test-Harness/
 Source0:        http://www.cpan.org/authors/id/O/OV/OVID/Test-Harness-%{version}.tar.gz
+# Do not warn on tainted test without PERL5LIB environment variable,
+# bug #1091376, CPAN RT#85106, in 3.29
+Patch0:         Test-Harness-3.28-Do-not-warn-on-tainted-test-without-PERL5LIB-envirom.patch
 BuildArch:      noarch
 BuildRequires:  perl
 BuildRequires:  perl(ExtUtils::MakeMaker)
@@ -60,6 +63,7 @@ writing new code consider using TAP::Harness directly instead.
 
 %prep
 %setup -q -n Test-Harness-%{version}
+%patch0 -p1
 
 %build
 perl Makefile.PL INSTALLDIRS=vendor
@@ -81,6 +85,10 @@ make test
 %{_mandir}/man3/*
 
 %changelog
+* Mon Apr 28 2014 Petr Pisar <ppisar at redhat.com> - 3.28-4
+- Do not warn on tainted test without PERL5LIB environment variable
+  (bug #1091376)
+
 * Sun Aug 04 2013 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 3.28-3
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild
 


More information about the scm-commits mailing list