[gnome-terminal/f20-gnome-3-12] Restore transparency

Debarshi Ray rishi at fedoraproject.org
Wed May 14 17:03:58 UTC 2014


commit 4c8a6b5a770d4c1ba380c33b704fcec39f123c29
Author: Debarshi Ray <debarshir at gnome.org>
Date:   Wed May 14 19:02:40 2014 +0200

    Restore transparency

 0001-Restore-transparency-gnome-3-12.patch |  261 ++++++++++++++++++++++++++++
 gnome-terminal.spec                        |    8 +-
 2 files changed, 268 insertions(+), 1 deletions(-)
---
diff --git a/0001-Restore-transparency-gnome-3-12.patch b/0001-Restore-transparency-gnome-3-12.patch
new file mode 100644
index 0000000..e245998
--- /dev/null
+++ b/0001-Restore-transparency-gnome-3-12.patch
@@ -0,0 +1,261 @@
+From cd92f2088377bd2b5145ec56f4dab50adcf29881 Mon Sep 17 00:00:00 2001
+From: Debarshi Ray <debarshir at gnome.org>
+Date: Mon, 12 May 2014 14:57:18 +0200
+Subject: [PATCH] Restore transparency
+
+The transparency settings were removed as a side effect of
+2bff4b63ed3ceef6055e35563e9b0b33ad57349d
+
+This restores them and you will need a compositing window manager to
+use it. The background image setting, also known as faux transparency,
+was not restored.
+---
+ src/org.gnome.Terminal.gschema.xml |  9 ++++
+ src/profile-editor.c               | 10 +++++
+ src/profile-preferences.ui         | 92 ++++++++++++++++++++++++++++++++++++++
+ src/terminal-schemas.h             |  3 ++
+ src/terminal-screen.c              | 23 +++++++++-
+ src/terminal-window.c              |  7 +++
+ 6 files changed, 143 insertions(+), 1 deletion(-)
+
+diff --git a/src/org.gnome.Terminal.gschema.xml b/src/org.gnome.Terminal.gschema.xml
+index 94eeae9..ab7e914 100644
+--- a/src/org.gnome.Terminal.gschema.xml
++++ b/src/org.gnome.Terminal.gschema.xml
+@@ -326,6 +326,15 @@
+       <default>'current'</default>
+       <summary>Which encoding to use</summary>
+     </key>
++    <key name="use-transparent-background" type="b">
++      <default>false</default>
++      <summary>Whether to use a transparent background</summary>
++    </key>
++    <key name="background-transparency-percent" type="i">
++      <default>50</default>
++      <summary>Adjust the amount of transparency</summary>
++      <description>A value between 0 and 100, where 0 is opaque and 100 is fully transparent.</description>
++    </key>
+   </schema>
+ 
+   <!-- Keybinding settings -->
+diff --git a/src/profile-editor.c b/src/profile-editor.c
+index 1b3e855..9ab66c8 100644
+--- a/src/profile-editor.c
++++ b/src/profile-editor.c
+@@ -1026,6 +1026,16 @@ terminal_profile_edit (GSettings  *profile,
+                    gtk_builder_get_object (builder, "rewrap-on-resize-checkbutton"),
+                    "active", G_SETTINGS_BIND_GET | G_SETTINGS_BIND_SET);
+ 
++  g_settings_bind (profile, TERMINAL_PROFILE_USE_TRANSPARENT_BACKGROUND,
++                   gtk_builder_get_object (builder, "use-transparent-background"),
++                   "active", G_SETTINGS_BIND_GET | G_SETTINGS_BIND_SET);
++  g_settings_bind (profile, TERMINAL_PROFILE_USE_TRANSPARENT_BACKGROUND,
++                   gtk_builder_get_object (builder, "background-transparent-scale-box"),
++                   "sensitive", G_SETTINGS_BIND_GET | G_SETTINGS_BIND_NO_SENSITIVITY);
++  g_settings_bind (profile, TERMINAL_PROFILE_BACKGROUND_TRANSPARENCY_PERCENT,
++                   gtk_builder_get_object (builder, "background-transparent-adjustment"),
++                   "value", G_SETTINGS_BIND_GET | G_SETTINGS_BIND_SET);
++
+   terminal_util_bind_mnemonic_label_sensitivity (editor);
+ 
+   terminal_util_dialog_focus_widget (editor, widget_name);
+diff --git a/src/profile-preferences.ui b/src/profile-preferences.ui
+index f648938..2b068f0 100644
+--- a/src/profile-preferences.ui
++++ b/src/profile-preferences.ui
+@@ -23,6 +23,11 @@
+     <property name="step_increment">1</property>
+     <property name="page_increment">100</property>
+   </object>
++  <object class="GtkAdjustment" id="background-transparent-adjustment">
++    <property name="upper">100</property>
++    <property name="step_increment">1</property>
++    <property name="page_increment">10</property>
++  </object>
+   <object class="GtkListStore" id="model1">
+     <columns>
+       <!-- column-name gchararray -->
+@@ -1228,6 +1233,93 @@
+                                 <property name="position">1</property>
+                               </packing>
+                             </child>
++                            <child>
++                              <object class="GtkBox" id="use-transparent-background-box">
++                                <property name="visible">True</property>
++                                <property name="can_focus">False</property>
++                                <property name="orientation">horizontal</property>
++                                <property name="spacing">12</property>
++                                <child>
++                                  <object class="GtkCheckButton" id="use-transparent-background">
++                                    <property name="label" translatable="yes">Use t_ransparent background</property>
++                                    <property name="visible">True</property>
++                                    <property name="can_focus">True</property>
++                                    <property name="receives_default">False</property>
++                                    <property name="use_underline">True</property>
++                                    <property name="xalign">0</property>
++                                    <property name="draw_indicator">True</property>
++                                  </object>
++                                  <packing>
++                                    <property name="expand">False</property>
++                                    <property name="fill">False</property>
++                                    <property name="position">0</property>
++                                  </packing>
++                                </child>
++                                <child>
++                                  <object class="GtkBox" id="background-transparent-scale-box">
++                                    <property name="visible">True</property>
++                                    <property name="can_focus">False</property>
++                                    <property name="orientation">horizontal</property>
++                                    <property name="spacing">6</property>
++                                    <child>
++                                      <object class="GtkLabel" id="background-transparent-min-label">
++                                        <property name="visible">True</property>
++                                        <property name="can_focus">False</property>
++                                        <property name="xalign">0.5</property>
++                                        <property name="label" translatable="yes">none</property>
++                                        <style>
++                                          <class name="dim-label"/>
++                                        </style>
++                                      </object>
++                                      <packing>
++                                        <property name="expand">False</property>
++                                        <property name="fill">False</property>
++                                        <property name="position">0</property>
++                                      </packing>
++                                    </child>
++                                    <child>
++                                      <object class="GtkScale" id="background-transparent-scale">
++                                        <property name="visible">True</property>
++                                        <property name="can_focus">True</property>
++                                        <property name="adjustment">background-transparent-adjustment</property>
++                                        <property name="draw_value">False</property>
++                                      </object>
++                                      <packing>
++                                        <property name="expand">True</property>
++                                        <property name="fill">True</property>
++                                        <property name="position">1</property>
++                                      </packing>
++                                    </child>
++                                    <child>
++                                      <object class="GtkLabel" id="background-transparent-max-label">
++                                        <property name="visible">True</property>
++                                        <property name="can_focus">False</property>
++                                        <property name="xalign">0.5</property>
++                                        <property name="label" translatable="yes">full</property>
++                                        <style>
++                                          <class name="dim-label"/>
++                                        </style>
++                                      </object>
++                                      <packing>
++                                        <property name="expand">False</property>
++                                        <property name="fill">False</property>
++                                        <property name="position">2</property>
++                                      </packing>
++                                    </child>
++                                  </object>
++                                  <packing>
++                                    <property name="expand">True</property>
++                                    <property name="fill">True</property>
++                                    <property name="position">1</property>
++                                  </packing>
++                                </child>
++                              </object>
++                              <packing>
++                                <property name="expand">True</property>
++                                <property name="fill">True</property>
++                                <property name="position">2</property>
++                              </packing>
++                            </child>
+                           </object>
+                         </child>
+                       </object>
+diff --git a/src/terminal-schemas.h b/src/terminal-schemas.h
+index 443cf7b..c242857 100644
+--- a/src/terminal-schemas.h
++++ b/src/terminal-schemas.h
+@@ -65,6 +65,9 @@ G_BEGIN_DECLS
+ #define TERMINAL_PROFILE_VISIBLE_NAME_KEY               "visible-name"
+ #define TERMINAL_PROFILE_WORD_CHARS_KEY                 "word-chars"
+ 
++#define TERMINAL_PROFILE_USE_TRANSPARENT_BACKGROUND      "use-transparent-background"
++#define TERMINAL_PROFILE_BACKGROUND_TRANSPARENCY_PERCENT "background-transparency-percent"
++
+ #define TERMINAL_SETTING_CONFIRM_CLOSE_KEY              "confirm-close"
+ #define TERMINAL_SETTING_DEFAULT_SHOW_MENUBAR_KEY       "default-show-menubar"
+ #define TERMINAL_SETTING_DARK_THEME_KEY                 "dark-theme"
+diff --git a/src/terminal-screen.c b/src/terminal-screen.c
+index ac971c0..43334b6 100644
+--- a/src/terminal-screen.c
++++ b/src/terminal-screen.c
+@@ -792,7 +792,9 @@ terminal_screen_profile_changed_cb (GSettings     *profile,
+       prop_name == I_(TERMINAL_PROFILE_BACKGROUND_COLOR_KEY) ||
+       prop_name == I_(TERMINAL_PROFILE_BOLD_COLOR_SAME_AS_FG_KEY) ||
+       prop_name == I_(TERMINAL_PROFILE_BOLD_COLOR_KEY) ||
+-      prop_name == I_(TERMINAL_PROFILE_PALETTE_KEY))
++      prop_name == I_(TERMINAL_PROFILE_PALETTE_KEY) ||
++      prop_name == I_(TERMINAL_PROFILE_USE_TRANSPARENT_BACKGROUND) ||
++      prop_name == I_(TERMINAL_PROFILE_BACKGROUND_TRANSPARENCY_PERCENT))
+     update_color_scheme (screen);
+ 
+   if (!prop_name || prop_name == I_(TERMINAL_PROFILE_AUDIBLE_BELL_KEY))
+@@ -857,6 +859,9 @@ update_color_scheme (TerminalScreen *screen)
+   GdkRGBA fg, bg, bold, theme_fg, theme_bg;
+   GdkRGBA *boldp;
+   GtkStyleContext *context;
++  GtkWidget *toplevel;
++  gboolean transparent;
++  guint16 opacity;
+ 
+   context = gtk_widget_get_style_context (widget);
+   gtk_style_context_get_color (context, GTK_STATE_FLAG_NORMAL, &theme_fg);
+@@ -880,6 +885,22 @@ update_color_scheme (TerminalScreen *screen)
+   vte_terminal_set_colors_rgba (VTE_TERMINAL (screen), &fg, &bg,
+                                 colors, n_colors);
+   vte_terminal_set_color_bold_rgba (VTE_TERMINAL (screen), boldp);
++
++  transparent = g_settings_get_boolean (profile, TERMINAL_PROFILE_USE_TRANSPARENT_BACKGROUND);
++  if (transparent)
++    {
++      gint transparency_percent;
++
++      transparency_percent = g_settings_get_int (profile, TERMINAL_PROFILE_BACKGROUND_TRANSPARENCY_PERCENT);
++      opacity = (guint16) (G_MAXUINT16 * (100 - transparency_percent) / 100.0);
++    }
++  else
++    opacity = G_MAXUINT16;
++
++  vte_terminal_set_opacity (VTE_TERMINAL (screen), opacity);
++  toplevel = gtk_widget_get_toplevel (GTK_WIDGET (screen));
++  if (toplevel != NULL && gtk_widget_is_toplevel (toplevel))
++    gtk_widget_set_app_paintable (toplevel, transparent);
+ }
+ 
+ void
+diff --git a/src/terminal-window.c b/src/terminal-window.c
+index db06b3f..2adcba8 100644
+--- a/src/terminal-window.c
++++ b/src/terminal-window.c
+@@ -2619,6 +2619,8 @@ terminal_window_init (TerminalWindow *window)
+   TerminalWindowPrivate *priv;
+   TerminalApp *app;
+   TerminalSettingsList *profiles_list;
++  GdkScreen *screen;
++  GdkVisual *visual;
+   GtkActionGroup *action_group;
+   GtkAction *action;
+   GtkUIManager *manager;
+@@ -2634,6 +2636,11 @@ terminal_window_init (TerminalWindow *window)
+ 
+   gtk_widget_init_template (GTK_WIDGET (window));
+ 
++  screen = gtk_widget_get_screen (GTK_WIDGET (window));
++  visual = gdk_screen_get_rgba_visual (screen);
++  if (visual != NULL)
++    gtk_widget_set_visual (GTK_WIDGET (window), visual);
++
+   uuid_generate (u);
+   uuid_unparse (u, uuidstr);
+   priv->uuid = g_strdup (uuidstr);
+-- 
+1.9.0
+
diff --git a/gnome-terminal.spec b/gnome-terminal.spec
index 7654f10..8d29cde 100644
--- a/gnome-terminal.spec
+++ b/gnome-terminal.spec
@@ -8,13 +8,15 @@
 Summary: Terminal emulator for GNOME
 Name: gnome-terminal
 Version: 3.12.2
-Release: 1%{?dist}
+Release: 2%{?dist}
 License: GPLv3+ and GFDL
 Group: User Interface/Desktops
 URL: http://www.gnome.org/
 #VCS: git:git://git.gnome.org/gnome-terminal
 Source0: http://download.gnome.org/sources/gnome-terminal/3.12/gnome-terminal-%{version}.tar.xz
 
+Patch0: 0001-Restore-transparency-gnome-3-12.patch
+
 BuildRequires: glib2-devel >= %{glib2_version}
 BuildRequires: GConf2-devel
 BuildRequires: gtk3-devel >= %{gtk3_version}
@@ -49,6 +51,7 @@ option to the right-click context menu in Nautilus.
 
 %prep
 %setup -q
+%patch0 -p1
 
 %build
 %configure --disable-static --with-gtk=3.0 --with-nautilus-extension
@@ -89,6 +92,9 @@ fi
 %{_libdir}/nautilus/extensions-3.0/libterminal-nautilus.so
 
 %changelog
+* Wed May 14 2014 Debarshi Ray <rishi at fedorapeople.org> - 3.12.2-2
+- Restore transparency
+
 * Wed May 14 2014 Richard Hughes <rhughes at redhat.com> - 3.12.2-1
 - Update to 3.12.2
 


More information about the scm-commits mailing list