[sssd] Fix tests on big-endian

Jakub Hrozek jhrozek at fedoraproject.org
Mon Jun 2 09:09:05 UTC 2014


commit 6307570cd8e18ab84b7752bc20a99eb050d8b082
Author: Jakub Hrozek <jhrozek at redhat.com>
Date:   Mon Jun 2 11:08:39 2014 +0200

    Fix tests on big-endian

 0001-TESTS-fgetc-returns-int-not-char.patch |   27 +++++++++++++++++++++++++++
 sssd.spec                                   |    9 +++++++--
 2 files changed, 34 insertions(+), 2 deletions(-)
---
diff --git a/0001-TESTS-fgetc-returns-int-not-char.patch b/0001-TESTS-fgetc-returns-int-not-char.patch
new file mode 100644
index 0000000..2bd2ea6
--- /dev/null
+++ b/0001-TESTS-fgetc-returns-int-not-char.patch
@@ -0,0 +1,27 @@
+From 86f9acd3579c36fe4b198b8ec63b364620eee6e2 Mon Sep 17 00:00:00 2001
+From: Jakub Hrozek <jhrozek at redhat.com>
+Date: Mon, 2 Jun 2014 10:59:46 +0200
+Subject: [PATCH] TESTS: fgetc returns int, not char
+
+We used "char c = fgetc()" where we should have used "int c = fgetc()"
+This bug caused errors on big-endian architectures.
+---
+ src/tests/sss_config-tests.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/tests/sss_config-tests.c b/src/tests/sss_config-tests.c
+index 18ce8d8bf8e8abc2afea2350a0d4e8274f4ffc77..1b2608978affbc7cc1a253b9863fd691117757a4 100644
+--- a/src/tests/sss_config-tests.c
++++ b/src/tests/sss_config-tests.c
+@@ -261,7 +261,7 @@ check_file_content(const char *filename, const char *expected)
+ {
+     FILE *file = NULL;
+     size_t i;
+-    char c;
++    int c;
+     bool result;
+ 
+     file = fopen(filename, "r");
+-- 
+1.9.0
+
diff --git a/sssd.spec b/sssd.spec
index b5a4a8e..51ffe80 100644
--- a/sssd.spec
+++ b/sssd.spec
@@ -14,7 +14,7 @@
 
 Name: sssd
 Version: 1.12.0
-Release: 1%{?dist}.beta1
+Release: 2%{?dist}.beta1
 Group: Applications/System
 Summary: System Security Services Daemon
 License: GPLv3+
@@ -23,6 +23,7 @@ Source0: https://fedorahosted.org/released/sssd/%{name}-%{version}beta1.tar.gz
 BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)
 
 ### Patches ###
+Patch0001:  0001-TESTS-fgetc-returns-int-not-char.patch
 
 ### Dependencies ###
 Requires: sssd-common = %{version}-%{release}
@@ -798,7 +799,11 @@ fi
 %postun -n libsss_idmap -p /sbin/ldconfig
 
 %changelog
-* Fri May 30 2014 Jakub Hrozek <jhrozek at redhat.com> - 1.10.0-1.alpha1
+* Mon Jun 02 2014 Jakub Hrozek <jhrozek at redhat.com> - 1.10.0-2.beta1
+- Fix tests on big-endian
+- Fix previous changelog entry
+
+* Fri May 30 2014 Jakub Hrozek <jhrozek at redhat.com> - 1.10.0-1.beta1
 - New upstream release 1.12 beta1
 - https://fedorahosted.org/sssd/wiki/Releases/Notes-1.12.0beta1
 


More information about the scm-commits mailing list