[sirius] Don't use message as a format string

Bruno Wolff III bruno at fedoraproject.org
Wed Jun 11 02:23:42 UTC 2014


commit 9905272dae353559bdd14c344d803e1d1f3dc427
Author: Bruno Wolff III <bruno at wolff.to>
Date:   Tue Jun 10 21:23:04 2014 -0500

    Don't use message as a format string

 format-fix.patch |   11 +++++++++++
 sirius.spec      |    8 +++++++-
 2 files changed, 18 insertions(+), 1 deletions(-)
---
diff --git a/format-fix.patch b/format-fix.patch
new file mode 100644
index 0000000..aa349d7
--- /dev/null
+++ b/format-fix.patch
@@ -0,0 +1,11 @@
+--- src/sirius.c.orig	2014-06-10 21:17:26.835266408 -0500
++++ src/sirius.c	2014-06-10 21:18:00.948602038 -0500
+@@ -180,7 +180,7 @@
+ 
+ 	paus = 1;
+ 
+-	box = gtk_message_dialog_new (GTK_WINDOW (window), GTK_DIALOG_MODAL, GTK_MESSAGE_INFO, GTK_BUTTONS_OK, message);
++	box = gtk_message_dialog_new (GTK_WINDOW (window), GTK_DIALOG_MODAL, GTK_MESSAGE_INFO, GTK_BUTTONS_OK, '%s', message);
+ 	gtk_dialog_run (GTK_DIALOG(box));
+ 	gtk_widget_destroy(box);
+ 
diff --git a/sirius.spec b/sirius.spec
index 8b703d3..36cbc76 100644
--- a/sirius.spec
+++ b/sirius.spec
@@ -1,6 +1,6 @@
 Name:		sirius
 Version:	0.8.0
-Release:	24%{?dist}
+Release:	25%{?dist}
 
 Summary:	Reversi game for Gnome
 Group:		Amusements/Games
@@ -12,6 +12,8 @@ License:	GPLv2+
 Source0:	%{name}-%{version}.tar.gz
 Patch0:         sirius-desktop.patch
 Patch1:         sirius-libm.patch
+# Don't use message as a format string
+Patch2:         format-fix.patch
 BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 
 BuildRequires:	desktop-file-utils
@@ -41,6 +43,7 @@ transpositions and a less expensive evaluation function.
 %setup -q
 %patch0
 %patch1
+%patch2 -b .format-fix
 
 
 %build
@@ -79,6 +82,9 @@ desktop-file-install                 --delete-original	\
 
 
 %changelog
+* Tue Jun 10 2014 Bruno Wolff III <bruno at wolff.to> - 0.8.0-25
+- Don't use message as a format string
+
 * Sun Jun 08 2014 Fedora Release Engineering <rel-eng at lists.fedoraproject.org> - 0.8.0-24
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild
 


More information about the scm-commits mailing list